Parse settings from Azure Devops Extension #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
its/src/test/java/com/sonar/it/scanner/msbuild/ScannerMSBuildTest.java
Outdated
Show resolved
Hide resolved
its/src/test/java/com/sonar/it/scanner/msbuild/ScannerMSBuildTest.java
Outdated
Show resolved
Hide resolved
its/src/test/java/com/sonar/it/scanner/msbuild/ScannerMSBuildTest.java
Outdated
Show resolved
Hide resolved
its/src/test/java/com/sonar/it/scanner/msbuild/ScannerMSBuildTest.java
Outdated
Show resolved
Hide resolved
csaba-sagi-sonarsource
suggested changes
Jun 7, 2022
andrei-epure-sonarsource
force-pushed
the
andrei/1207
branch
from
6bb5ed6
to
ab8dca4
Compare
| String normalProjectKey = TestUtils.hasModules(ORCHESTRATOR) ? "my.project:my.project:B93B287C-47DB-4406-9EAB-653BCF7D20DC" : "my.project:Normal"; | ||
| String testProjectKey = TestUtils.hasModules(ORCHESTRATOR) ? "my.project:my.project:2DC588FC-16FB-42F8-9FDA-193852E538AF" : "my.project:Test"; | ||
| private void testExcludedAndTest(ScannerForMSBuild build, String projectKeyName, Path projectDir, String token, int expectedTestProjectIssues, boolean simulateAzureDevopsEnvironment) { | ||
| String normalProjectKey = TestUtils.hasModules(ORCHESTRATOR) |
There was a problem hiding this comment.
I opened #1248 to remove hasModules()
outside the scope of this PR
andrei-epure-sonarsource
added a commit
that referenced
this pull request
Jun 8, 2022
its/src/test/java/com/sonar/it/scanner/msbuild/ScannerMSBuildTest.java
Outdated
Show resolved
Hide resolved
csaba-sagi-sonarsource
suggested changes
Jun 9, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1207