CI: Use private VM for all pipeline steps #1873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costin-zaharia-sonarsource
force-pushed
the
costin/private-vm
branch
4 times, most recently
from
a683821
to
c8ed6ef
Compare
| @@ -90,7 +90,6 @@ public void InstallTargetsFile_Overwrite() | |||
| var msBuildPathSettings = new MsBuildPathSettings(); | |||
|
|
|||
| InstallTargetsFileAndAssert(sourceTargetsContent1, expectCopy: true); | |||
| msBuildPathSettings.GetImportBeforePaths().Should().HaveCount(7, "Expecting six destination directories"); | |||
There was a problem hiding this comment.
I had to remove the assertion since it's not always valid. Depending on the machine configuration, the scanner can add copy the target file in more than 6 directories.
e.g. copy the files in both system32 and SysWOW64 folders
2024-02-09T15:10:56.0361009Z DEBUG: Installed SonarQube.Integration.ImportBefore.targets to C:\Windows\system32\config\systemprofile\AppData\Local\Microsoft\MSBuild\4.0\Microsoft.Common.targets\ImportBefore
2024-02-09T15:10:56.0361432Z DEBUG: Installed SonarQube.Integration.ImportBefore.targets to C:\Windows\system32\config\systemprofile\AppData\Local\Microsoft\MSBuild\10.0\Microsoft.Common.targets\ImportBefore
2024-02-09T15:10:56.0361850Z DEBUG: Installed SonarQube.Integration.ImportBefore.targets to C:\Windows\system32\config\systemprofile\AppData\Local\Microsoft\MSBuild\11.0\Microsoft.Common.targets\ImportBefore
2024-02-09T15:10:56.0362270Z DEBUG: Installed SonarQube.Integration.ImportBefore.targets to C:\Windows\system32\config\systemprofile\AppData\Local\Microsoft\MSBuild\12.0\Microsoft.Common.targets\ImportBefore
2024-02-09T15:10:56.0362680Z DEBUG: Installed SonarQube.Integration.ImportBefore.targets to C:\Windows\system32\config\systemprofile\AppData\Local\Microsoft\MSBuild\14.0\Microsoft.Common.targets\ImportBefore
2024-02-09T15:10:56.0363080Z DEBUG: Installed SonarQube.Integration.ImportBefore.targets to C:\Windows\system32\config\systemprofile\AppData\Local\Microsoft\MSBuild\15.0\Microsoft.Common.targets\ImportBefore
2024-02-09T15:10:56.0363546Z DEBUG: Installed SonarQube.Integration.ImportBefore.targets to C:\Windows\system32\config\systemprofile\AppData\Local\Microsoft\MSBuild\Current\Microsoft.Common.targets\ImportBefore
2024-02-09T15:10:56.0363977Z DEBUG: Installed SonarQube.Integration.ImportBefore.targets to C:\Windows\SysWOW64\config\systemprofile\AppData\Local\Microsoft\MSBuild\4.0\Microsoft.Common.targets\ImportBefore
2024-02-09T15:10:56.0364373Z DEBUG: Installed SonarQube.Integration.ImportBefore.targets to C:\Windows\SysWOW64\config\systemprofile\AppData\Local\Microsoft\MSBuild\10.0\Microsoft.Common.targets\ImportBefore
2024-02-09T15:10:56.0364765Z DEBUG: Installed SonarQube.Integration.ImportBefore.targets to C:\Windows\SysWOW64\config\systemprofile\AppData\Local\Microsoft\MSBuild\11.0\Microsoft.Common.targets\ImportBefore
2024-02-09T15:10:56.0365163Z DEBUG: Installed SonarQube.Integration.ImportBefore.targets to C:\Windows\SysWOW64\config\systemprofile\AppData\Local\Microsoft\MSBuild\12.0\Microsoft.Common.targets\ImportBefore
2024-02-09T15:10:56.0365558Z DEBUG: Installed SonarQube.Integration.ImportBefore.targets to C:\Windows\SysWOW64\config\systemprofile\AppData\Local\Microsoft\MSBuild\14.0\Microsoft.Common.targets\ImportBefore
2024-02-09T15:10:56.0365942Z DEBUG: Installed SonarQube.Integration.ImportBefore.targets to C:\Windows\SysWOW64\config\systemprofile\AppData\Local\Microsoft\MSBuild\15.0\Microsoft.Common.targets\ImportBefore
2024-02-09T15:10:56.0366342Z DEBUG: Installed SonarQube.Integration.ImportBefore.targets to C:\Windows\SysWOW64\config\systemprofile\AppData\Local\Microsoft\MSBuild\Current\Microsoft.Common.targets\ImportBefore
2024-02-09T15:10:56.0366819Z DEBUG: Installed SonarQube.Integration.targets to C:\sonar-ci\_work\1\s\TestResults\Deploy_SYSTEM 20240209T151053\45\sonarqube\bin\targets
c8ed6ef
to
f742593
Compare
costin-zaharia-sonarsource
force-pushed
the
costin/private-vm
branch
from
f742593
to
773a497
Compare
- depending on the machine configuration the scanner can install the targets in more than 6 directories.
costin-zaharia-sonarsource
force-pushed
the
costin/private-vm
branch
from
70d41a1
to
f4f2ee3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.