Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix analysis on MacOSX with .NET 8 when begin runtime doesn't match with build runtime #1892

Merged
merged 11 commits into from Mar 22, 2024
Merged

Fix analysis on MacOSX with .NET 8 when begin runtime doesn't match with build runtime #1892

merged 11 commits into from Mar 22, 2024

Conversation

zsolt-kolbay-sonarsource
Copy link
Contributor

Backporting the Mac OS fix for .NET 8.0 to version 5.15

@github-actions github-actions bot added this to In progress in S4NET Kanban Mar 19, 2024
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource force-pushed the Zsolt/hotfix-MacOs-.NET8-fix branch 2 times, most recently from f844504 to 7c5d525 Compare March 20, 2024 15:50
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource changed the base branch from Zsolt/hotfix-5.15.1 to branch-5.15.1 March 21, 2024 15:54
@github-actions github-actions bot moved this from In progress to Review in progress in S4NET Kanban Mar 21, 2024
@costin-zaharia-sonarsource
Copy link
Member

We need to change the dedicated base branch to 5.15 so that it can handle future minor releases.

costin-zaharia-sonarsource
costin-zaharia-sonarsource requested changes Mar 21, 2024
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good but we need to change the base branch.

@github-actions github-actions bot moved this from Review in progress to In progress in S4NET Kanban Mar 21, 2024
@costin-zaharia-sonarsource costin-zaharia-sonarsource changed the base branch from branch-5.15.1 to branch-5.15 March 21, 2024 17:11
costin-zaharia-sonarsource
costin-zaharia-sonarsource approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

S4NET Kanban automation moved this from In progress to Reviewer approved Mar 21, 2024
@costin-zaharia-sonarsource
Copy link
Member

@zsolt-kolbay-sonarsource Please do not squash!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@costin-zaharia-sonarsource costin-zaharia-sonarsource merged commit caf5f1a into branch-5.15 Mar 22, 2024
26 checks passed
S4NET Kanban automation moved this from Reviewer approved to Done Mar 22, 2024
@costin-zaharia-sonarsource costin-zaharia-sonarsource deleted the Zsolt/hotfix-MacOs-.NET8-fix branch March 22, 2024 08:10
@costin-zaharia-sonarsource
Copy link
Member

Backported from #1863

@costin-zaharia-sonarsource costin-zaharia-sonarsource changed the title Fix analysis on MacOSX with .NET 8 when begin runtime doesn't match w… Fix analysis on MacOSX with .NET 8 when begin runtime doesn't match with build runtime Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costin-zaharia-sonarsource costin-zaharia-sonarsource costin-zaharia-sonarsource approved these changes

Assignees

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource

Labels
None yet
Projects
S4NET Kanban
  
Done
Milestone
Hotfix 5.15.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zsolt-kolbay-sonarsource @costin-zaharia-sonarsource @sebastien-marichal @malena-ebert-sonarsource @mary-georgiou-sonarsource