Replace Moq with NSubstitute #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristian-ambrosini-sonarsource
requested a review
from pavel-mikula-sonarsource
CristianAmbrosini
assigned CristianAmbrosini and unassigned cristian-ambrosini-sonarsource
pavel-mikula-sonarsource
requested changes
Apr 23, 2024
Tests/SonarScanner.MSBuild.PreProcessor.Test/AnalysisConfigGeneratorTests.cs
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/SonarCloudWebServerTest.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/SonarCloudWebServerTest.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/SonarCloudWebServerTest.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/SonarCloudWebServerTest.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/TargetsInstallerTests.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/TargetsInstallerTests.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/TargetsInstallerTests.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.Shim.Test/PropertiesFileGeneratorTests.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.TFS.Test/CoverageReportProcessorTests.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned cristian-ambrosini-sonarsource and unassigned pavel-mikula-sonarsource
CristianAmbrosini
force-pushed
the
cristian/replace-moq
branch
from
83d8555
to
1f0a4a8
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
CristianAmbrosini
assigned pavel-mikula-sonarsource and unassigned cristian-ambrosini-sonarsource
pavel-mikula-sonarsource
requested changes
May 16, 2024
Tests/SonarScanner.MSBuild.PreProcessor.Test/Infrastructure/HttpMessageHandlerMock.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/Infrastructure/HttpMessageHandlerMock.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/Infrastructure/HttpMessageHandlerMock.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/Infrastructure/HttpMessageHandlerMock.cs
Outdated
Show resolved
Hide resolved
Comment on lines
430
to
433
| new(async (request, cancellationToken) => request.RequestUri switch | ||
| { | ||
| var url when url == new Uri(cacheFullUrl) => new HttpResponseMessage | ||
| { |
There was a problem hiding this comment.
What about making there a fuent API like
new HttpMessageHandlerMock()
.AddResponse(URL, new StringContent(...)),
.AddResponse(URL, ....)
and then, the method would just iterate a list of responses and return 404 otherwise.
A token could be a ctor parameter.
There was a problem hiding this comment.
I think it's a bit of an over-engineered solution for the usage that we require, open to discussing it
There was a problem hiding this comment.
We're building framework that will be reused in the future. Just the next sprint about bootstrapper will use this again. The problem I see is that the mock is too hard to use and produces code that is too hard to read (constructor inside ternary inside lambda inside constructor).
Please create a follow up PR that will change this.
github-actions
bot
assigned cristian-ambrosini-sonarsource and unassigned pavel-mikula-sonarsource
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
pavel-mikula-sonarsource
requested changes
Jun 12, 2024
Tests/SonarScanner.MSBuild.PreProcessor.Test/Infrastructure/HttpMessageHandlerMock.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned cristian-ambrosini-sonarsource and unassigned cristian-ambrosini-sonarsource
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
|
github-actions
bot
assigned cristian-ambrosini-sonarsource and unassigned cristian-ambrosini-sonarsource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: each commit is replacing moq in a single project