Provide the scanner as a .net core global tool #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
valhristov
reviewed
Jun 11, 2018
| <Project Sdk="Microsoft.NET.Sdk" InitialTargets="DownloadScannerCli"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>$(ScannerNetFxVersion);$(ScannerNetCoreAppVersion);$(ScannerNetCoreGlobalToolVersion)</TargetFrameworks> |
There was a problem hiding this comment.
It is ok to move the constants here or to hardcode if we have only one project
There was a problem hiding this comment.
We use them in multiple places (for ScannerNetCoreGlobalToolVersion it is 2 places).
| <TargetFiles Include="$(SourcesRoot)\SonarScanner.MSBuild.Tasks\Targets\SonarQube.Integration.ImportBefore.targets" /> | ||
|
|
||
| <!-- Dlls --> | ||
| <ScannerFiles Include="$(SourcesRoot)\SonarScanner.MSBuild\bin\$(Configuration)\$(TargetFramework)\SonarQube.Analysis.xml" /> |
There was a problem hiding this comment.
Wouldn't copy local work as well? E.g. could we collect binaries from this project's output folder, instead of browsing the others?
There was a problem hiding this comment.
It would probably but I spent enough time improving that for the current sprint.
Evangelink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #417