SCANNPM-2 Detect Platform #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+22
to
+24
| preset: 'ts-jest', | ||
| testEnvironment: 'node', | ||
| collectCoverageFrom: ['src/**/*.{js,ts}'], |
There was a problem hiding this comment.
added support for ts, but I think this won't work with the js tests that exist. so need to cleanup and make sure we are left with no js tests 😅
lucas-paulger-sonarsource
force-pushed
the
feature/lp/add-platform-check
branch
from
e974a3e
to
ff7b7e7
Compare
Comment on lines
+26
to
+28
| log(LogLevel.DEBUG, 'Finding platform info'); | ||
| const platformInfo = getPlatformInfo(); | ||
| log(LogLevel.INFO, 'Platform: ', platformInfo); |
There was a problem hiding this comment.
I need to conditionally skip this with the presence of sonar.scanner.skipArchDetection
@7PH let me know if you have any process or suggestion on how we want to do this 🙇🏻
There was a problem hiding this comment.
After this PR you'll get the properties object available right before these lines, so we'll be able to use the object to decide whether to detect or not
7PH
reviewed
Apr 15, 2024
7PH
approved these changes
Apr 16, 2024
lucas-paulger-sonarsource
force-pushed
the
feature/lp/add-platform-check
branch
from
47c8e9f
to
020d58d
Compare
lucas-paulger-sonarsource
merged commit d8fc335
into
feature/MMF-3712
0 of 4 checks passed
7PH
pushed a commit
that referenced
this pull request
May 3, 2024
7PH
pushed a commit
that referenced
this pull request
May 3, 2024
lucas-paulger-sonarsource
added a commit
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.