SCANNPM-5 Update CI tasks #127
Conversation
lucas-paulger-sonarsource
changed the base branch from
feature/MMF-3712
to
feature/lp/cleanup-migrate-old-unit-tests
lucas-paulger-sonarsource
force-pushed
the
feature/lp/update-ci-tasks
branch
7 times, most recently
from
02f41f3
to
1d8ea40
Compare
| //TODO: return to true once SC has the new provisioning mechanism in place | ||
| return false; |
There was a problem hiding this comment.
this was to force the scanner to run the scanner-cli for SC. this needs to be reverted before we merge)
| @@ -87,7 +87,7 @@ describe('java', () => { | |||
| ...MOCKED_PROPERTIES, | |||
| [ScannerProperty.SonarScannerInternalIsSonarCloud]: 'true', | |||
| }), | |||
| ).toBe(true); | |||
| ).toBe(false); // TODO: return to true once SC has the new provisioning mechanism in place | |||
There was a problem hiding this comment.
this also need to be reverted, just modified to test the CI is passing
.npmignore
Outdated
There was a problem hiding this comment.
I needed to add this so that npm publish would include the build directory. The other alternative was to NOT .gitignore the build directory, but the files don't conform to the prettier settings because they are minified.
I am open to a better solution here
There was a problem hiding this comment.
I think if we set files: ["build/**"] in the package.json, then the build folder will automatically be included in the released package (even if it's gitignored)
There was a problem hiding this comment.
https://docs.npmjs.com/cli/v8/commands/npm-publish#files-included-in-package
I would say we need to only release build folder and the cli src\bin\sonar-scanner. All the rest can be ignored.
lucas-paulger-sonarsource
force-pushed
the
feature/lp/update-ci-tasks
branch
from
1d8ea40
to
561be42
Compare
lucas-paulger-sonarsource
changed the base branch from
feature/lp/cleanup-migrate-old-unit-tests
to
feature/MMF-3712
lucas-paulger-sonarsource
force-pushed
the
feature/lp/update-ci-tasks
branch
from
a0f288d
to
e195ebf
Compare
lucas-paulger-sonarsource
force-pushed
the
feature/lp/update-ci-tasks
branch
from
e195ebf
to
771a56b
Compare
| // Skip if not a .js file | ||
| if (!fileName.endsWith('.js')) { | ||
| continue; | ||
| } | ||
|
|
There was a problem hiding this comment.
added back for the *.d.ts files
|
# Conflicts: # src/properties.ts # test/unit/config.test.js
Co-authored-by: Victor <victor.diez@sonarsource.com>
Co-authored-by: Victor <victor.diez@sonarsource.com>
Co-authored-by: Victor <victor.diez@sonarsource.com>
No description provided.