Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCANNPM-2 Sanitize input passed to child processes #135

Conversation

vdiez
Copy link

@vdiez vdiez commented Apr 30, 2024

  • Be sure we’re safe in regards to Child process | Node.js v22.0.0 Documentationand we’re compatible with Node 22

  • Use regex validation on what we pass through CLI args to spawn(..)

  • Do not use shell-quote (can break some values: eg a PATH containing @)

@vdiez vdiez marked this pull request as ready for review April 30, 2024 12:58
Copy link
Member

@7PH 7PH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, a few NPs (non-functional) 👍

Also there are lots of commits, would probably make sense to consoldate them and drop the merge commit in the middle 👀

src/platform.ts Outdated Show resolved Hide resolved
src/scan.ts Outdated Show resolved Hide resolved
src/platform.ts Outdated Show resolved Hide resolved
src/runner.ts Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@vdiez vdiez merged commit 61a47c8 into feature/MMF-3712 May 1, 2024
0 of 4 checks passed
@vdiez vdiez deleted the feature/br/scannpm-24-sanitize-input-passed-to-child-processes branch May 1, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants