Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to run analyses with npx #33

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

yassin-kammoun-sonarsource

No description provided.

README.md Outdated Show resolved Hide resolved
Copy link

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@yassin-kammoun-sonarsource
Copy link
Author

I'm slightly uncomfortable having this under Installation, would it fit better under Usage or somewhere else?

Makes sense. What about now?

Copy link

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check my suggestion, otherwise LGTM!

README.md Outdated Show resolved Hide resolved
@yassin-kammoun-sonarsource
Copy link
Author

@ilia-kebets-sonarsource I pushed two additional commits:

  • I noticed that the versions of the package.json dependencies were not fixed.
  • I added TypeScript as a devDependency because TypeScript ESLint seems to need it.

I am not sure why TypeScript was not a devDependency until now. The build was failing because it was missing:

added 383 packages in 5.686s

> sonarqube-scanner@3.0.0 check-format /tmp/cirrus-ci-build
> prettier --list-different "{src,test}/**/!(*.lint).js"


> sonarqube-scanner@3.0.0 license /tmp/cirrus-ci-build
> eslint --ext js,ts src test tools scripts .


Oops! Something went wrong! :(

ESLint: 8.30.0

Error: Failed to load parser '@typescript-eslint/parser' declared in '.eslintrc.js': Cannot find module 'typescript'
Require stack:
- /tmp/cirrus-ci-build/node_modules/@typescript-eslint/typescript-estree/dist/convert.js
- /tmp/cirrus-ci-build/node_modules/@typescript-eslint/typescript-estree/dist/ast-converter.js
- /tmp/cirrus-ci-build/node_modules/@typescript-eslint/typescript-estree/dist/parser.js
- /tmp/cirrus-ci-build/node_modules/@typescript-eslint/typescript-estree/dist/index.js
- /tmp/cirrus-ci-build/node_modules/@typescript-eslint/parser/dist/parser.js
- /tmp/cirrus-ci-build/node_modules/@typescript-eslint/parser/dist/index.js

How come it didn't fail before? Am I missing something here?

I am requesting another review :)

Copy link

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we must find a fix for the qa test failing because of:

npm ERR! code ENOSELF
npm ERR! Refusing to install package with name "sonarqube-scanner" under a package
npm ERR! also called "sonarqube-scanner". Did you name your project the same
npm ERR! as the dependency you're installing?
npm ERR! 
npm ERR! For more information, see:
npm ERR!     <https://docs.npmjs.com/cli/install#limitations-of-npms-install-algorithm>

Co-authored-by: Ilia Kebets <104737176+ilia-kebets-sonarsource@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants