-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions to run analyses with npx #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
Makes sense. What about now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check my suggestion, otherwise LGTM!
e8c6d7c
to
496aa2a
Compare
@ilia-kebets-sonarsource I pushed two additional commits:
I am not sure why TypeScript was not a devDependency until now. The build was failing because it was missing:
How come it didn't fail before? Am I missing something here? I am requesting another review :) |
496aa2a
to
d3fdb26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we must find a fix for the qa test failing because of:
npm ERR! code ENOSELF
npm ERR! Refusing to install package with name "sonarqube-scanner" under a package
npm ERR! also called "sonarqube-scanner". Did you name your project the same
npm ERR! as the dependency you're installing?
npm ERR!
npm ERR! For more information, see:
npm ERR! <https://docs.npmjs.com/cli/install#limitations-of-npms-install-algorithm>
0fca1a4
to
30aa1c8
Compare
Co-authored-by: Ilia Kebets <104737176+ilia-kebets-sonarsource@users.noreply.github.com>
30aa1c8
to
0f39b53
Compare
Kudos, SonarCloud Quality Gate passed! |
No description provided.