Fix build and QA #35
Merged
Fix build and QA #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saberduck
force-pushed
the
fix_qa
branch
7 times, most recently
from
9c8cfce
to
5655a59
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Comment on lines
+83
to
+85
| node_version_script: | ||
| - node --version | ||
| - npm --version |
There was a problem hiding this comment.
Was this added for debugging purposes or do you intentionally need these?
There was a problem hiding this comment.
it's for debugging, but I would keep them, it makes it easier to understand the version of node used
yassin-kammoun-sonarsource
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.