Add support for https proxy #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| @@ -159,16 +159,27 @@ or alternatively set variable in `.npmrc` | |||
|
|
|||
| ## Download behind proxy | |||
|
|
|||
| In order to be able to download binaries when you're behind a proxy it will be enough to set http_proxy environment variable. | |||
| In order to be able to download binaries when you're behind a proxy it will be enough to set the `http_proxy` environment | |||
| variable. The `https_proxy` environment variable is supported as well, should the mirror be using the HTTPS protocol. | |||
There was a problem hiding this comment.
isn't it the proxy server that's using HTTPS, and not the mirror?
There was a problem hiding this comment.
I guess both, right? It would be weird do proxy a HTTP mirror with HTTPS
There was a problem hiding this comment.
weird but not impossible
There was a problem hiding this comment.
ok, it's the download helper who will handle the proper proxy to use. it will all depend on the URL you download from. so I think it makes sense the way it's phrased here
ilia-kebets-sonarsource
requested changes
Aug 30, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented in #43. Cherry-picked their commit