Add support for Basic authentication on SonarScanner mirrors #57
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
@victor-diez-sonarsource regarding your documentation change, the password protection in this PR is for the mirror itself (i.e. the Nexus instance), not the proxy - proxy auth is separate, as part of the proxy URL. |
|
Thanks @interone-ms. Yes, I understand that. But you mentioned: but there was nothing after that. So I understood you were referring to the authentication for proxies, which was already documented in the first PR. can you please clarify? |
| config.httpOptions.httpsRequestOptions = { agent: proxyAgent }; | ||
| } | ||
|
|
||
| if (finalUrl.username !== '' || finalUrl.password !== '') { |
There was a problem hiding this comment.
What would happen if one of them is missing? Should the two of them be required?
There was a problem hiding this comment.
should be fine. http basic auth allows for empty usernames or passwords
|
@interone-ms Please let me know if it's all clear or you meant to say something else in the README. Would like to merge this before next release. |
|
@victor-diez-sonarsource you're right, good catch. Looks like I reordered stuff during writing and didn't update the wording. |
Cherry-picked from #44