Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PR coverage #84

Merged
merged 13 commits into from
Nov 21, 2023
Merged

Fix PR coverage #84

merged 13 commits into from
Nov 21, 2023

Conversation

vdiez
Copy link

@vdiez vdiez commented Nov 20, 2023

No description provided.

ilia-kebets-sonarsource
ilia-kebets-sonarsource requested changes Nov 21, 2023
View reviewed changes
Copy link

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, could you please add a comment about why you do that (it's a fork) and where is the solution taken from (cirrus docs)

@vdiez
Copy link
Author

vdiez commented Nov 21, 2023

done! :)

@vdiez vdiez removed the request for review from saberduck November 21, 2023 08:55
ilia-kebets-sonarsource
ilia-kebets-sonarsource approved these changes Nov 21, 2023
View reviewed changes
Copy link

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good Job!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

ilia-kebets-sonarsource
ilia-kebets-sonarsource approved these changes Nov 21, 2023
View reviewed changes
Copy link

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdiez vdiez merged commit b1d453a into master Nov 21, 2023
7 checks passed
@vdiez vdiez deleted the fix-pr-coverage branch November 21, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilia-kebets-sonarsource ilia-kebets-sonarsource ilia-kebets-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vdiez @ilia-kebets-sonarsource