Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSTS-301 Fix semver check for compatibility with SQ >= 10.0 #251

Merged
merged 2 commits into from Jun 5, 2023
Merged

VSTS-301 Fix semver check for compatibility with SQ >= 10.0 #251

merged 2 commits into from Jun 5, 2023

Conversation

mickael-caro-sonarsource
Copy link
Contributor

Please review our contribution guidelines.

And please ensure your pull request adheres to the following guidelines:

  • Please explain your motives to contribute this change: what problem you are trying to fix, what improvement you are trying to make
  • Use the following formatting style: SonarSource/sonar-developer-toolset
  • Provide a unit test for any code you changed
  • If there is a JIRA ticket available, please make your commits and pull request start with the ticket ID (VSTS-XXXX)

@alexanderameye
Copy link

alexanderameye commented Apr 26, 2023 •
edited

As a temporary workaround, this worked for me.

- task: CopyFiles@2
  inputs:
    SourceFolder: $(Agent.TempDirectory)
    Contents: '**/report-task.txt'
    TargetFolder: $(Agent.BuildDirectory)

@jaz2038
Copy link

jaz2038 commented May 17, 2023

@mickael-caro-sonarsource do you know if a merge here is likely soon?

wouter-admiraal-sonarsource
wouter-admiraal-sonarsource approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . I just have one doubt regarding the new tests.

commonv5/ts/sonarqube/__tests__/TaskReport-test.ts Outdated Show resolved Hide resolved
@mickael-caro-sonarsource mickael-caro-sonarsource changed the base branch from master to sprint-1 June 5, 2023 07:08
@mickael-caro-sonarsource mickael-caro-sonarsource merged commit d8b2469 into sprint-1 Jun 5, 2023
8 checks passed
@mickael-caro-sonarsource mickael-caro-sonarsource deleted the fix/mc/VSTS-301-fix-semver-check branch June 5, 2023 09:26
mickael-caro-sonarsource added a commit that referenced this pull request Jun 13, 2023
@mickael-caro-sonarsource
VSTS-301 Fix semver check for compatibility with SQ >= 10.0 (#251)
639e945
@Nemuroscythe Nemuroscythe mentioned this pull request Jan 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouter-admiraal-sonarsource wouter-admiraal-sonarsource wouter-admiraal-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@mickael-caro-sonarsource @alexanderameye @jaz2038 @wouter-admiraal-sonarsource