Skip to content

Commit

Permalink
Revert "SCSCANGHA-16 Support passing args with spaces (#79)" (#83)
Browse files Browse the repository at this point in the history
This reverts commit d08d592.
  • Loading branch information
csaba-feher-sonarsource committed Jun 13, 2024
1 parent 13d84ab commit e44258b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/qa.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,12 @@ jobs:
- name: Run action with args
uses: ./
with:
args: >-
"-Dsonar.someArg=a value with spaces" -Dsonar.scanner.dumpToFile=./output.properties
args: -Dsonar.someArg=aValue -Dsonar.scanner.dumpToFile=./output.properties
env:
SONAR_TOKEN: FAKE_TOKEN
- name: Assert
run: |
./test/assertFileContains ./output.properties "sonar.someArg=a value with spaces"
./test/assertFileContains ./output.properties "sonar.someArg=aValue"
projectBaseDirInputTest:
name: >
'projectBaseDir' input
Expand Down
4 changes: 1 addition & 3 deletions entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,4 @@ if [[ "$RUNNER_DEBUG" == '1' ]]; then
fi

unset JAVA_HOME

eval "args=(${INPUT_ARGS})"
sonar-scanner $debug_flag "-Dsonar.projectBaseDir=${INPUT_PROJECTBASEDIR}" "-Dsonar.host.url=${SONARCLOUD_URL}" "${args[@]}"
sonar-scanner $debug_flag -Dsonar.projectBaseDir=${INPUT_PROJECTBASEDIR} -Dsonar.host.url=${SONARCLOUD_URL} ${INPUT_ARGS}

0 comments on commit e44258b

Please sign in to comment.