SLCORE-686 Don't load OS-specific SSL store on Windows #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtech-suchy-sonarsource
force-pushed
the
fix/vs/SLCORE-686_loading_system_certs_on_windows
branch
from
991feaa
to
f7fc406
Compare
henryju
reviewed
Mar 21, 2024
| @@ -105,6 +108,10 @@ private static SSLContext configureSsl(SslConfig sslConfig, @Nullable Predicate< | |||
| return sslFactoryBuilder.build().getSslContext(); | |||
| } | |||
|
|
|||
| private static boolean isNotWindows() { | |||
| return System.getProperty("os.name") != null && !System.getProperty("os.name").startsWith("Windows"); | |||
There was a problem hiding this comment.
Maybe adding a dependency on commons-lang3 and using SystemUtils would be safer/more maintainable.
There was a problem hiding this comment.
Yes, I was pondering that as well
vojtech-suchy-sonarsource
force-pushed
the
fix/vs/SLCORE-686_loading_system_certs_on_windows
branch
3 times, most recently
from
19269c4
to
4637a38
Compare
vojtech-suchy-sonarsource
force-pushed
the
fix/vs/SLCORE-686_loading_system_certs_on_windows
branch
from
4637a38
to
74ce43b
Compare
vojtech-suchy-sonarsource
force-pushed
the
fix/vs/SLCORE-686_loading_system_certs_on_windows
branch
from
74ce43b
to
d450e8f
Compare
|
vojtech-suchy-sonarsource
deleted the
fix/vs/SLCORE-686_loading_system_certs_on_windows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.