SLCORE-777 Perform issue tracking before raising issue #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirill-knize-sonarsource
changed the title
kirill-knize-sonarsource
force-pushed
the
task/kk/issue-tracking
branch
2 times, most recently
from
cd0e846
to
f56be07
Compare
kirill-knize-sonarsource
force-pushed
the
task/dam/add-analysis-tracking-tests
branch
2 times, most recently
from
93bae13
to
375a1d2
Compare
kirill-knize-sonarsource
changed the base branch from
task/dam/add-analysis-tracking-tests
to
feature/analysis-tracking
kirill-knize-sonarsource
force-pushed
the
task/kk/issue-tracking
branch
from
f56be07
to
3af7a5d
Compare
kirill-knize-sonarsource
force-pushed
the
task/kk/issue-tracking
branch
from
a8f5a55
to
3628b3a
Compare
damien-urruty-sonarsource
approved these changes
May 2, 2024
| @@ -67,4 +82,16 @@ public Set<String> getReportedRuleKeys() { | |||
| public Set<SonarLanguage> getDetectedLanguages() { | |||
| return detectedLanguages; | |||
| } | |||
|
|
|||
| public List<RawIssue> getIssues() { | |||
There was a problem hiding this comment.
Maybe getRawIssues, to make things explicit? Same for the field name
| return issues; | ||
| } | ||
|
|
||
| public boolean isEnableTracking() { |
There was a problem hiding this comment.
Maybe isTrackingEnabled ?
| private void streamIssue(String configScopeId, UUID analysisId, Issue issue, ConcurrentHashMap<String, GetRuleDetailsResponse> ruleDetailsCache, | ||
| HashSet<String> reportedRuleKeys) { | ||
| private void streamIssue(String configScopeId, UUID analysisId, Issue issue, ConcurrentHashMap<String, RuleDetailsForAnalysis> ruleDetailsCache, | ||
| List<RawIssue> raisedIssues) { |
There was a problem hiding this comment.
I think this should be called rawIssues. Raw issues are not necessarily raised, as raised to me means that we would display them to the user. In fact raiseIssues could even be an alternative name for publishIssues
| */ | ||
| @Deprecated(since = "10.2") |
There was a problem hiding this comment.
If we deprecate this one, we can also deprecate didRaiseIssues for the client
kirill-knize-sonarsource
force-pushed
the
task/kk/issue-tracking
branch
from
bc713a3
to
ba61e79
Compare
|
kirill-knize-sonarsource
merged commit 6ab2e0c
into
feature/analysis-tracking
11 checks passed
damien-urruty-sonarsource
added a commit
that referenced
this pull request
May 7, 2024
* Add medium tests for issue tracking * SLCORE-777 Perform issue tracking before raising issue --------- Co-authored-by: Damien Urruty <damien.urruty@sonarsource.com>
damien-urruty-sonarsource
added a commit
that referenced
this pull request
May 10, 2024
* Add medium tests for issue tracking * SLCORE-777 Perform issue tracking before raising issue --------- Co-authored-by: Damien Urruty <damien.urruty@sonarsource.com>
damien-urruty-sonarsource
added a commit
that referenced
this pull request
May 13, 2024
* Add medium tests for issue tracking * SLCORE-777 Perform issue tracking before raising issue --------- Co-authored-by: Damien Urruty <damien.urruty@sonarsource.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.