Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API changes docs and tests #961

Merged
merged 6 commits into from
May 7, 2024
Merged

API changes docs and tests #961

merged 6 commits into from
May 7, 2024

Conversation

kirill-knize-sonarsource
Copy link
Contributor

No description provided.

@kirill-knize-sonarsource kirill-knize-sonarsource changed the base branch from master to feature/analysis-tracking May 3, 2024 16:38
damien-urruty-sonarsource
damien-urruty-sonarsource reviewed May 6, 2024
View reviewed changes
Copy link
Contributor

@damien-urruty-sonarsource damien-urruty-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some changes are required. I have a doubt about the grammar in some sentences of the doc, we can maybe have a look together

API_CHANGES.md Show resolved Hide resolved
API_CHANGES.md Outdated Show resolved Hide resolved
API_CHANGES.md Outdated Show resolved Hide resolved
API_CHANGES.md Outdated Show resolved Hide resolved
API_CHANGES.md Outdated Show resolved Hide resolved
medium-tests/src/test/java/mediumtest/tracking/IssueTrackingMediumTests.java Outdated Show resolved Hide resolved
medium-tests/src/test/java/mediumtest/tracking/IssueTrackingMediumTests.java Outdated Show resolved Hide resolved
...rg/sonarsource/sonarlint/core/rpc/protocol/backend/tracking/TrackWithServerIssuesParams.java Show resolved Hide resolved
@kirill-knize-sonarsource kirill-knize-sonarsource marked this pull request as ready for review May 6, 2024 14:47
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented May 6, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
87.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@kirill-knize-sonarsource kirill-knize-sonarsource merged commit 5ab0f76 into feature/analysis-tracking May 7, 2024
11 checks passed
@kirill-knize-sonarsource kirill-knize-sonarsource deleted the task/api-changes-doc-plus-tests branch May 7, 2024 04:36
damien-urruty-sonarsource added a commit that referenced this pull request May 7, 2024
@kirill-knize-sonarsource @damien-urruty-sonarsource
API changes docs and tests (#961)
7125c00 
* API changes documentation, improved deprecations, some tests

---------

Co-authored-by: Damien Urruty <damien.urruty@sonarsource.com>
damien-urruty-sonarsource added a commit that referenced this pull request May 10, 2024
@kirill-knize-sonarsource @damien-urruty-sonarsource
API changes docs and tests (#961)
4fecaf1 
* API changes documentation, improved deprecations, some tests

---------

Co-authored-by: Damien Urruty <damien.urruty@sonarsource.com>
damien-urruty-sonarsource added a commit that referenced this pull request May 13, 2024
@kirill-knize-sonarsource @damien-urruty-sonarsource
API changes docs and tests (#961)
2b856d7 
* API changes documentation, improved deprecations, some tests

---------

Co-authored-by: Damien Urruty <damien.urruty@sonarsource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damien-urruty-sonarsource damien-urruty-sonarsource Awaiting requested review from damien-urruty-sonarsource

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kirill-knize-sonarsource @damien-urruty-sonarsource