Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased maximum length of SonarQube server configuration items #18

Merged
merged 2 commits into from Apr 19, 2016
Merged

Conversation

aguther
Copy link
Contributor

@aguther aguther commented Apr 18, 2016

I tested the new version 2.0.0 and discovered that with that version we are unable to use our SonarQube in the company due to the restriction of the Server URL to 50 characters.

Therefore this pull-request to increase this. What I asked myself is the reason to limit this setting to 50. Is this a limitation of the core library?

@henryju
Copy link
Member

henryju commented Apr 18, 2016

@aguther @dbmeneses AFAIK there is no limit in sonarlint-core, so we can even consider the 150 limit to be an issue. Why having a limit in the first place?

@dbmeneses
Copy link
Contributor

dbmeneses commented Apr 18, 2016

For most fields, the limit is just to sanitize the input and avoid very long values that could be a problem for certain parts of the UI.
For the name, the limit is important as it is used to name a directory and OSs have limits for path lengths (and also because it's displayed in several places in the UI).

Could you change the P/R and only set the 50-char length limit to the name?

@aguther
Copy link
Contributor Author

aguther commented Apr 18, 2016

I've made the changes and additionally renamed the variable to be more speaking.

Additional info:
I also made a short check on the eclipse plugin but there seems no limitation.

@dbmeneses dbmeneses merged commit 4d31b61 into SonarSource:master Apr 19, 2016
@dbmeneses
Copy link
Contributor

Thanks @aguther

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants