Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Threading Issue in GitEventsMonitor #5020

Closed
ugras-ergun-sonarsource opened this issue Nov 15, 2023 · 0 comments · Fixed by #5019
Closed

Fix the Threading Issue in GitEventsMonitor #5020

ugras-ergun-sonarsource opened this issue Nov 15, 2023 · 0 comments · Fixed by #5019
Assignees
@ugras-ergun-sonarsource
Labels
Type: Bug
Projects
SLVS Kanban
Milestone
7.4

Comments

@ugras-ergun-sonarsource
Copy link
Contributor

ugras-ergun-sonarsource commented Nov 15, 2023 •
edited

Description

When disposing of GitEventsMonitor and a head change triggered at the same time It would cause a race condition on underlying FileSystemWatcher and causes VS to freeze.

Reproduction

If you have a solution which checking out a earlier version triggers reloading of the solution also (this happens if the solution file changed between versions) will cause Visual Studio to freeze and killing the "devenv.exe" would be the only way to move forward.
@ugras-ergun-sonarsource ugras-ergun-sonarsource created this issue from a note in SLVS Kanban (Review in progress) Nov 15, 2023
Merged
@github-actions github-actions bot moved this from Review in progress to Reviewer approved in SLVS Kanban Nov 15, 2023
SLVS Kanban automation moved this from Reviewer approved to Done Nov 15, 2023
ugras-ergun-sonarsource added a commit that referenced this issue Nov 15, 2023
@ugras-ergun-sonarsource
Fix the Threading Issue in GitEventsMonitor (#5019)
dbf2515 
Fixes #5020
@ugras-ergun-sonarsource ugras-ergun-sonarsource added this to the 7.4 milestone Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ugras-ergun-sonarsource ugras-ergun-sonarsource

Labels
Type: Bug
Projects
No open projects
SLVS Kanban
Done
Milestone
7.4
Development

Successfully merging a pull request may close this issue.

Fix the Threading Issue in GitEventsMonitor SonarSource/sonarlint-visualstudio
1 participant
@ugras-ergun-sonarsource