Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make branch matching algorithm aligned with other SonarLint flavours. #5092

Closed
2 tasks done
ugras-ergun-sonarsource opened this issue Dec 7, 2023 · 2 comments
Closed
2 tasks done

Make branch matching algorithm aligned with other SonarLint flavours. #5092

ugras-ergun-sonarsource opened this issue Dec 7, 2023 · 2 comments
Assignees
@ugras-ergun-sonarsource
Labels
Area: Connected Mode Type: Improvement
Projects
SLVS Kanban
Milestone
7.8

Comments

@ugras-ergun-sonarsource
Copy link
Contributor

ugras-ergun-sonarsource commented Dec 7, 2023 •
edited

There are two differences between SLVS and other flavours.

  • We do not ignore short-lived branches. (only applicable to SC; in SQ there's no distinction of short-lived vs long-lived branches)
  • We need to prioritise main branch when there's a tie between branches.

Based on slack discussion: https://sonarsource.slack.com/archives/C03PE8P8TK6/p1701336633925369
@ugras-ergun-sonarsource ugras-ergun-sonarsource changed the title Make branch matching algorithm aligned with other SonarLint flavorus. Make branch matching algorithm aligned with other SonarLint flavours. Jan 24, 2024
@kevin-hinz
Copy link
Contributor

🙏 Please notify the Documentation Squad when this issue is started.
DOC-1043 is waiting to implement the changes to the docs.

@ugras-ergun-sonarsource
Copy link
Contributor Author

We haven't done a proper hardening sprint since this was created it'll be the top ticket when we do a hardening.

@ugras-ergun-sonarsource ugras-ergun-sonarsource added this to In progress in SLVS Kanban Mar 27, 2024
@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource added this to the 7.8 milestone Mar 27, 2024
Merged
ugras-ergun-sonarsource added a commit that referenced this issue Mar 28, 2024
@ugras-ergun-sonarsource
Short lived branches ignored on branch matching (#5331)
3088c71 
Part of #5092
Merged
@github-actions github-actions bot moved this from In progress to Review in progress in SLVS Kanban Mar 28, 2024
@github-actions github-actions bot moved this from Review in progress to Reviewer approved in SLVS Kanban Mar 28, 2024
ugras-ergun-sonarsource added a commit that referenced this issue Apr 2, 2024
@ugras-ergun-sonarsource
Prioritise "Main" when matching branches (#5332)
56d15c4 
Fixes #5092
SLVS Kanban automation moved this from Reviewer approved to Done Apr 2, 2024
georgii-borovinskikh-sonarsource pushed a commit that referenced this issue Apr 2, 2024
@ugras-ergun-sonarsource @georgii-borovinskikh-sonarsource
Short lived branches ignored on branch matching (#5331)
3a60413 
Part of #5092
georgii-borovinskikh-sonarsource pushed a commit that referenced this issue Apr 2, 2024
@ugras-ergun-sonarsource @georgii-borovinskikh-sonarsource
Prioritise "Main" when matching branches (#5332)
2caab3e 
Fixes #5092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ugras-ergun-sonarsource ugras-ergun-sonarsource

Labels
Area: Connected Mode Type: Improvement
Projects
No open projects
SLVS Kanban
Done
Milestone
7.8
Development

No branches or pull requests
4 participants
@pavel-mikula-sonarsource @ugras-ergun-sonarsource @kevin-hinz @georgii-borovinskikh-sonarsource