Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paths coming from VS solution should be trimmed #5328

Closed
AbbasNS opened this issue Mar 26, 2024 · 0 comments · Fixed by #5329
Closed

Paths coming from VS solution should be trimmed #5328

AbbasNS opened this issue Mar 26, 2024 · 0 comments · Fixed by #5329
Assignees
@AbbasNS
Labels
Area: Analyzer Language: CFamily C/C++ analysis Type: Bug
Projects
SLVS Kanban
Milestone
7.8

Comments

@AbbasNS
Copy link
Contributor

AbbasNS commented Mar 26, 2024

While CMake and the command line don't trim those paths, it seems that VS automatically trims them.
Outside of the VS solution, they aren't trimmed because a space at the beginning or end of a directory on Windows, while not recommended, is allowed.

The fact that we currently don't trim paths means that the analyzer might not find some paths when the user inserts an extra space by mistake in the VS project settings.
@AbbasNS AbbasNS mentioned this issue Mar 26, 2024
Merged
@github-actions github-actions bot added this to Review in progress in SLVS Kanban Mar 27, 2024
@github-actions github-actions bot moved this from Review in progress to Reviewer approved in SLVS Kanban Mar 27, 2024
georgii-borovinskikh-sonarsource pushed a commit that referenced this issue Mar 27, 2024
@AbbasNS
Trim paths loaded from VS in solution mode (#5329)
bf75513 
Fixes #5328
SLVS Kanban automation moved this from Reviewer approved to Done Mar 27, 2024
@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource added this to the 7.8 milestone Mar 27, 2024
georgii-borovinskikh-sonarsource pushed a commit that referenced this issue Apr 2, 2024
@AbbasNS @georgii-borovinskikh-sonarsource
Trim paths loaded from VS in solution mode (#5329)
f965b52 
Fixes #5328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AbbasNS AbbasNS

Labels
Area: Analyzer Language: CFamily C/C++ analysis Type: Bug
Projects
No open projects
SLVS Kanban
Done
Milestone
7.8
Development

Successfully merging a pull request may close this issue.

Trim paths loaded from VS in solution mode SonarSource/sonarlint-visualstudio
2 participants
@AbbasNS @georgii-borovinskikh-sonarsource