Drop support for VS2019 #5444
Merged
Drop support for VS2019 #5444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgii-borovinskikh-sonarsource
previously approved these changes
May 23, 2024
github-actions
bot
assigned ugras-ergun-sonarsource and unassigned ugras-ergun-sonarsource
github-actions
bot
assigned georgii-borovinskikh-sonarsource and unassigned ugras-ergun-sonarsource
github-actions
bot
moved this from Reviewer approved
to Review in progress
in SLVS Kanban
github-actions
bot
assigned georgii-borovinskikh-sonarsource and unassigned georgii-borovinskikh-sonarsource
georgii-borovinskikh-sonarsource
requested changes
May 23, 2024
| @@ -33,7 +33,6 @@ namespace SonarLint.VisualStudio.IssueVisualization.Security.OpenInIDE | |||
| [PackageRegistration(UseManagedResourcesOnly = true, AllowsBackgroundLoading = true)] | |||
| [Guid("5C38BF5B-F6D1-4232-A5B5-5664B6A19A91")] | |||
| // We want to start listening as soon as the IDE starts. | |||
| // Note: in VS2019, this will be when the new modal start page appears. | |||
There was a problem hiding this comment.
It was about vs17 to vs19. The info is still relevant. Change to Since vs19,...
There was a problem hiding this comment.
I think it's not that important since this is the default behaviour info about this change is not interesting anymore and I think it should've been removed when dropping 2017.
There was a problem hiding this comment.
I think it's valuable for someone to know that the shell initializes before you actually select any project, however this comment is not the most noticeable place, so up to you
src/Roslyn.Suppressions/Roslyn.Suppressions/SupportedSuppressionBuilder.g.cs
Outdated
Show resolved
Hide resolved
src/TypeScript/NodeJSLocator/LocationProviders/BundledNodeLocationsProvider.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned ugras-ergun-sonarsource and unassigned georgii-borovinskikh-sonarsource
|
Still says 2019 on some jobs |
it's handled by azure devops I'll change it there after this. |
github-actions
bot
assigned georgii-borovinskikh-sonarsource and unassigned ugras-ergun-sonarsource
georgii-borovinskikh-sonarsource
approved these changes
May 24, 2024
github-actions
bot
assigned ugras-ergun-sonarsource and unassigned georgii-borovinskikh-sonarsource
github-actions
bot
moved this from Review in progress
to Reviewer approved
in SLVS Kanban
|
ugras-ergun-sonarsource
merged commit 7fdfc25
into
feature/hardening-may-2024
8 checks passed
pavel-mikula-sonarsource
pushed a commit
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5345