Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQSCANGHA-27 Use GHA debug logging with scanner #120

Merged
merged 1 commit into from
May 22, 2024
Merged

SQSCANGHA-27 Use GHA debug logging with scanner #120

merged 1 commit into from
May 22, 2024

Conversation

istvan-bodo-sonarsource
Copy link
Contributor

No description provided.

henryju
henryju requested changes May 21, 2024
View reviewed changes
Copy link
Member

@henryju henryju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be possible to add a test for this change. Using the scanner simulation mode (-Dsonar.scanner.dumpToFile) you can then assert that the property sonar.verbose=true is there in the file.
See other tests for an example.

@istvan-bodo-sonarsource istvan-bodo-sonarsource marked this pull request as draft May 21, 2024 13:22
@SonarTech SonarTech force-pushed the ib/SQSCANGHA-27/use-gha-debug-logging branch 2 times, most recently from 6882665 to b4fb099 Compare May 21, 2024 13:56
@istvan-bodo-sonarsource istvan-bodo-sonarsource marked this pull request as ready for review May 21, 2024 14:25
henryju
henryju approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@henryju henryju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SonarTech SonarTech force-pushed the ib/SQSCANGHA-27/use-gha-debug-logging branch from b4fb099 to 880bceb Compare May 21, 2024 14:54
@istvan-bodo-sonarsource istvan-bodo-sonarsource merged commit 9bea6a4 into master May 22, 2024
8 checks passed
@SonarTech SonarTech deleted the ib/SQSCANGHA-27/use-gha-debug-logging branch May 23, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryju henryju henryju approved these changes

@antoine-vinot-sonarsource antoine-vinot-sonarsource Awaiting requested review from antoine-vinot-sonarsource

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@istvan-bodo-sonarsource @henryju