-
Notifications
You must be signed in to change notification settings - Fork 1.9k
/
GroupsActionTest.java
263 lines (223 loc) · 9.27 KB
/
GroupsActionTest.java
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
/*
* SonarQube, open source software quality management tool.
* Copyright (C) 2008-2014 SonarSource
* mailto:contact AT sonarsource DOT com
*
* SonarQube is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* SonarQube is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
package org.sonar.server.permission.ws;
import com.google.common.io.Resources;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
import org.junit.experimental.categories.Category;
import org.junit.rules.ExpectedException;
import org.sonar.api.resources.Qualifiers;
import org.sonar.api.security.DefaultGroups;
import org.sonar.api.server.ws.WebService.Param;
import org.sonar.api.server.ws.WebService.SelectionMode;
import org.sonar.api.utils.System2;
import org.sonar.api.web.UserRole;
import org.sonar.core.permission.GlobalPermissions;
import org.sonar.db.DbClient;
import org.sonar.db.DbSession;
import org.sonar.db.DbTester;
import org.sonar.db.component.ComponentDbTester;
import org.sonar.db.component.ComponentDto;
import org.sonar.db.component.ResourceTypesRule;
import org.sonar.db.user.GroupDto;
import org.sonar.db.user.GroupRoleDto;
import org.sonar.server.component.ComponentFinder;
import org.sonar.server.exceptions.BadRequestException;
import org.sonar.server.exceptions.ForbiddenException;
import org.sonar.server.exceptions.UnauthorizedException;
import org.sonar.server.permission.PermissionFinder;
import org.sonar.server.tester.UserSessionRule;
import org.sonar.server.usergroups.ws.UserGroupFinder;
import org.sonar.server.ws.WsActionTester;
import org.sonar.test.DbTests;
import static org.assertj.core.api.Assertions.assertThat;
import static org.sonar.api.server.ws.WebService.Param.SELECTED;
import static org.sonar.api.web.UserRole.ISSUE_ADMIN;
import static org.sonar.core.permission.GlobalPermissions.SCAN_EXECUTION;
import static org.sonar.core.permission.GlobalPermissions.SYSTEM_ADMIN;
import static org.sonar.db.component.ComponentTesting.newProjectDto;
import static org.sonar.db.component.ComponentTesting.newView;
import static org.sonar.server.permission.ws.WsPermissionParameters.PARAM_PERMISSION;
import static org.sonar.server.permission.ws.WsPermissionParameters.PARAM_PROJECT_KEY;
import static org.sonar.server.permission.ws.WsPermissionParameters.PARAM_PROJECT_ID;
import static org.sonar.test.JsonAssert.assertJson;
@Category(DbTests.class)
public class GroupsActionTest {
@Rule
public ExpectedException expectedException = ExpectedException.none();
@Rule
public UserSessionRule userSession = UserSessionRule.standalone();
@Rule
public DbTester db = DbTester.create(System2.INSTANCE);
ComponentDbTester componentDb = new ComponentDbTester(db);
ResourceTypesRule resourceTypes = new ResourceTypesRule().setRootQualifiers(Qualifiers.PROJECT, Qualifiers.VIEW, "DEV");
DbClient dbClient;
DbSession dbSession;
WsActionTester ws;
GroupsAction underTest;
@Before
public void setUp() {
dbClient = db.getDbClient();
dbSession = db.getSession();
PermissionFinder permissionFinder = new PermissionFinder(dbClient);
underTest = new GroupsAction(dbClient, userSession, permissionFinder, new PermissionDependenciesFinder(dbClient, new ComponentFinder(dbClient), new UserGroupFinder(dbClient), resourceTypes));
ws = new WsActionTester(underTest);
userSession.login("login").setGlobalPermissions(SYSTEM_ADMIN);
GroupDto group1 = insertGroup(new GroupDto().setName("group-1-name").setDescription("group-1-description"));
GroupDto group2 = insertGroup(new GroupDto().setName("group-2-name").setDescription("group-2-description"));
GroupDto group3 = insertGroup(new GroupDto().setName("group-3-name").setDescription("group-3-description"));
insertGroupRole(new GroupRoleDto().setGroupId(group1.getId()).setRole(SCAN_EXECUTION));
insertGroupRole(new GroupRoleDto().setGroupId(group2.getId()).setRole(SCAN_EXECUTION));
insertGroupRole(new GroupRoleDto().setGroupId(group3.getId()).setRole(SYSTEM_ADMIN));
}
@Test
public void search_for_groups_with_one_permission() {
String result = ws.newRequest()
.setParam(PARAM_PERMISSION, SCAN_EXECUTION)
.execute().getInput();
assertJson(result).isSimilarTo(Resources.getResource(getClass(), "GroupsActionTest/groups.json"));
}
@Test
public void search_with_selection() {
String result = ws.newRequest()
.setParam(PARAM_PERMISSION, GlobalPermissions.SCAN_EXECUTION)
.setParam(SELECTED, SelectionMode.ALL.value())
.execute().getInput();
assertThat(result).containsSequence(DefaultGroups.ANYONE, "group-1", "group-2", "group-3");
}
@Test
public void search_with_admin_does_not_return_anyone() {
String result = ws.newRequest()
.setParam(PARAM_PERMISSION, GlobalPermissions.SYSTEM_ADMIN)
.setParam(SELECTED, SelectionMode.ALL.value())
.execute().getInput();
assertThat(result).containsSequence("group-1", "group-2", "group-3")
.doesNotContain(DefaultGroups.ANYONE);
}
@Test
public void search_groups_with_pagination() {
String result = ws.newRequest()
.setParam(PARAM_PERMISSION, "scan")
.setParam(Param.PAGE_SIZE, "1")
.setParam(Param.PAGE, "2")
.execute().getInput();
assertThat(result).contains("group-2")
.doesNotContain("group-1")
.doesNotContain("group-3");
}
@Test
public void search_groups_with_query() {
String result = ws.newRequest()
.setParam(PARAM_PERMISSION, "scan")
.setParam(Param.TEXT_QUERY, "group-")
.execute().getInput();
assertThat(result)
.contains("group-1", "group-2", "group-3")
.doesNotContain(DefaultGroups.ANYONE);
}
@Test
public void search_groups_with_project_permissions() {
dbClient.componentDao().insert(dbSession, newProjectDto("project-uuid").setKey("project-key"));
ComponentDto project = dbClient.componentDao().selectOrFailByUuid(dbSession, "project-uuid");
GroupDto group = insertGroup(new GroupDto().setName("project-group-name"));
insertGroupRole(new GroupRoleDto()
.setGroupId(group.getId())
.setRole(ISSUE_ADMIN)
.setResourceId(project.getId()));
userSession.login().addProjectUuidPermissions(UserRole.ADMIN, "project-uuid");
String result = ws.newRequest()
.setParam(PARAM_PERMISSION, ISSUE_ADMIN)
.setParam(PARAM_PROJECT_ID, "project-uuid")
.execute().getInput();
assertThat(result).contains("project-group-name")
.doesNotContain("group-1")
.doesNotContain("group-2")
.doesNotContain("group-3");
}
@Test
public void search_groups_on_views() {
ComponentDto view = componentDb.insertComponent(newView("view-uuid").setKey("view-key"));
GroupDto group = insertGroup(new GroupDto().setName("project-group-name"));
insertGroupRole(new GroupRoleDto()
.setGroupId(group.getId())
.setRole(ISSUE_ADMIN)
.setResourceId(view.getId()));
String result = ws.newRequest()
.setParam(PARAM_PERMISSION, ISSUE_ADMIN)
.setParam(PARAM_PROJECT_ID, "view-uuid")
.execute().getInput();
assertThat(result).contains("project-group-name")
.doesNotContain("group-1")
.doesNotContain("group-2")
.doesNotContain("group-3");
}
@Test
public void fail_if_project_permission_without_project() {
expectedException.expect(BadRequestException.class);
ws.newRequest()
.setParam(PARAM_PERMISSION, UserRole.ISSUE_ADMIN)
.execute();
}
@Test
public void fail_if_not_logged_in() {
expectedException.expect(UnauthorizedException.class);
userSession.anonymous();
ws.newRequest()
.setParam(PARAM_PERMISSION, "scan")
.execute();
}
@Test
public void fail_if_insufficient_privileges() {
expectedException.expect(ForbiddenException.class);
userSession.login("login");
ws.newRequest()
.setParam(PARAM_PERMISSION, "scan")
.execute();
}
@Test
public void fail_if_permission_is_not_specified() {
expectedException.expect(IllegalArgumentException.class);
ws.newRequest()
.execute();
}
@Test
public void fail_if_project_uuid_and_project_key_are_provided() {
expectedException.expect(BadRequestException.class);
dbClient.componentDao().insert(dbSession, newProjectDto("project-uuid").setKey("project-key"));
ws.newRequest()
.setParam(PARAM_PERMISSION, SCAN_EXECUTION)
.setParam(PARAM_PROJECT_ID, "project-uuid")
.setParam(PARAM_PROJECT_KEY, "project-key")
.execute();
}
private GroupDto insertGroup(GroupDto group) {
GroupDto result = dbClient.groupDao().insert(dbSession, group);
commit();
return result;
}
private void insertGroupRole(GroupRoleDto groupRole) {
dbClient.roleDao().insertGroupRole(dbSession, groupRole);
commit();
}
private void commit() {
dbSession.commit();
}
}