-
Notifications
You must be signed in to change notification settings - Fork 1.9k
/
UserPermissionDaoTest.java
390 lines (323 loc) · 19 KB
/
UserPermissionDaoTest.java
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
/*
* SonarQube
* Copyright (C) 2009-2016 SonarSource SA
* mailto:contact AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
package org.sonar.db.permission;
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.List;
import javax.annotation.Nullable;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
import org.sonar.api.utils.System2;
import org.sonar.db.DbClient;
import org.sonar.db.DbSession;
import org.sonar.db.DbTester;
import org.sonar.db.component.ComponentDto;
import org.sonar.db.organization.OrganizationDto;
import org.sonar.db.organization.OrganizationTesting;
import org.sonar.db.user.UserDto;
import static java.util.Arrays.asList;
import static org.assertj.core.api.Assertions.assertThat;
import static org.sonar.api.web.UserRole.ISSUE_ADMIN;
import static org.sonar.api.web.UserRole.USER;
import static org.sonar.core.permission.GlobalPermissions.PROVISIONING;
import static org.sonar.core.permission.GlobalPermissions.SYSTEM_ADMIN;
import static org.sonar.db.component.ComponentTesting.newProjectDto;
import static org.sonar.db.organization.OrganizationTesting.newOrganizationDto;
import static org.sonar.db.user.UserTesting.newUserDto;
public class UserPermissionDaoTest {
@Rule
public DbTester dbTester = DbTester.create(System2.INSTANCE);
private UserPermissionDao underTest = new UserPermissionDao();
private UserDto user1 = newUserDto().setLogin("login1").setName("Marius").setActive(true);
private UserDto user2 = newUserDto().setLogin("login2").setName("Marie").setActive(true);
private UserDto user3 = newUserDto().setLogin("login3").setName("Bernard").setActive(true);
private ComponentDto project1 = newProjectDto();
private ComponentDto project2 = newProjectDto();
private DbSession dbSession = dbTester.getSession();
@Before
public void setUp() throws Exception {
DbClient dbClient = dbTester.getDbClient();
dbClient.userDao().insert(dbSession, user1);
dbClient.userDao().insert(dbSession, user2);
dbClient.userDao().insert(dbSession, user3);
dbClient.componentDao().insert(dbSession, project1);
dbClient.componentDao().insert(dbSession, project2);
dbTester.commit();
}
@Test
public void select_global_permissions() {
UserPermissionDto global1 = addGlobalPermissionOnDefaultOrganization(SYSTEM_ADMIN, user1);
UserPermissionDto global2 = addGlobalPermissionOnDefaultOrganization(SYSTEM_ADMIN, user2);
UserPermissionDto global3 = addGlobalPermissionOnDefaultOrganization(PROVISIONING, user2);
UserPermissionDto project1Perm = addProjectPermissionOnDefaultOrganization(USER, user3, project1);
// global permissions of users who has at least one global permission, ordered by user name then permission
PermissionQuery query = PermissionQuery.builder().withAtLeastOnePermission().build();
expectPermissions(query, null, global2, global3, global1);
// default query returns all permissions
query = PermissionQuery.builder().build();
expectPermissions(query, null, project1Perm, global2, global3, global1);
// return empty list if non-null but empty logins
expectPermissions(query, Collections.emptyList());
// global permissions of user1
query = PermissionQuery.builder().withAtLeastOnePermission().build();
expectPermissions(query, asList(user1.getLogin()), global1);
// global permissions of user2
query = PermissionQuery.builder().withAtLeastOnePermission().build();
expectPermissions(query, asList(user2.getLogin()), global2, global3);
// global permissions of user1, user2 and another one
query = PermissionQuery.builder().withAtLeastOnePermission().build();
expectPermissions(query, asList(user1.getLogin(), user2.getLogin(), "missing"), global2, global3, global1);
// empty global permissions if login does not exist
query = PermissionQuery.builder().withAtLeastOnePermission().build();
expectPermissions(query, asList("missing"));
// empty global permissions if user does not have any
query = PermissionQuery.builder().withAtLeastOnePermission().build();
expectPermissions(query, asList(user3.getLogin()));
// user3 has no global permissions
query = PermissionQuery.builder().withAtLeastOnePermission().build();
expectPermissions(query, asList(user3.getLogin()));
// global permissions "admin"
query = PermissionQuery.builder().setPermission(SYSTEM_ADMIN).build();
expectPermissions(query, null, global2, global1);
// empty if nobody has the specified global permission
query = PermissionQuery.builder().setPermission("missing").build();
expectPermissions(query, null);
// search by user name (matches 2 users)
query = PermissionQuery.builder().withAtLeastOnePermission().setSearchQuery("Mari").build();
expectPermissions(query, null, global2, global3, global1);
// search by user name (matches 2 users) and global permission
query = PermissionQuery.builder().setSearchQuery("Mari").setPermission(PROVISIONING).build();
expectPermissions(query, null, global3);
// search by user name (no match)
query = PermissionQuery.builder().setSearchQuery("Unknown").build();
expectPermissions(query, null);
}
@Test
public void select_project_permissions() {
addGlobalPermissionOnDefaultOrganization(SYSTEM_ADMIN, user1);
UserPermissionDto perm1 = addProjectPermissionOnDefaultOrganization(USER, user1, project1);
UserPermissionDto perm2 = addProjectPermissionOnDefaultOrganization(ISSUE_ADMIN, user1, project1);
UserPermissionDto perm3 = addProjectPermissionOnDefaultOrganization(ISSUE_ADMIN, user2, project1);
addProjectPermissionOnDefaultOrganization(ISSUE_ADMIN, user3, project2);
// project permissions of users who has at least one permission on this project
PermissionQuery query = PermissionQuery.builder().withAtLeastOnePermission().setComponentUuid(project1.uuid()).build();
expectPermissions(query, null, perm3, perm2, perm1);
// project permissions of user1
query = PermissionQuery.builder().withAtLeastOnePermission().setComponentUuid(project1.uuid()).build();
expectPermissions(query, asList(user1.getLogin()), perm2, perm1);
// project permissions of user2
query = PermissionQuery.builder().withAtLeastOnePermission().setComponentUuid(project1.uuid()).build();
expectPermissions(query, asList(user2.getLogin()), perm3);
// project permissions of user2 and another one
query = PermissionQuery.builder().withAtLeastOnePermission().setComponentUuid(project1.uuid()).build();
expectPermissions(query, asList(user2.getLogin(), "missing"), perm3);
// empty project permissions if login does not exist
query = PermissionQuery.builder().withAtLeastOnePermission().setComponentUuid(project1.uuid()).build();
expectPermissions(query, asList("missing"));
// empty project permissions if user does not have any
query = PermissionQuery.builder().withAtLeastOnePermission().setComponentUuid(project1.uuid()).build();
expectPermissions(query, asList(user3.getLogin()));
// empty if nobody has the specified global permission
query = PermissionQuery.builder().setPermission("missing").setComponentUuid(project1.uuid()).build();
expectPermissions(query, null);
// search by user name (matches 2 users), users with at least one permission
query = PermissionQuery.builder().setSearchQuery("Mari").withAtLeastOnePermission().setComponentUuid(project1.uuid()).build();
expectPermissions(query, null, perm3, perm2, perm1);
// search by user name (matches 2 users) and project permission
query = PermissionQuery.builder().setSearchQuery("Mari").setPermission(ISSUE_ADMIN).setComponentUuid(project1.uuid()).build();
expectPermissions(query, null, perm3, perm2);
// search by user name (no match)
query = PermissionQuery.builder().setSearchQuery("Unknown").setComponentUuid(project1.uuid()).build();
expectPermissions(query, null);
// permissions of unknown project
query = PermissionQuery.builder().setComponentUuid("missing").withAtLeastOnePermission().build();
expectPermissions(query, null);
}
@Test
public void countUsersByProjectPermission() {
addGlobalPermissionOnDefaultOrganization(SYSTEM_ADMIN, user1);
addProjectPermissionOnDefaultOrganization(USER, user1, project1);
addProjectPermissionOnDefaultOrganization(ISSUE_ADMIN, user1, project1);
addProjectPermissionOnDefaultOrganization(ISSUE_ADMIN, user2, project1);
addProjectPermissionOnDefaultOrganization(ISSUE_ADMIN, user2, project2);
// no projects -> return empty list
assertThat(underTest.countUsersByProjectPermission(dbSession, Collections.emptyList())).isEmpty();
// one project
expectCount(asList(project1.getId()),
new CountPerProjectPermission(project1.getId(), USER, 1),
new CountPerProjectPermission(project1.getId(), ISSUE_ADMIN, 2));
// multiple projects
expectCount(asList(project1.getId(), project2.getId(), -1L),
new CountPerProjectPermission(project1.getId(), USER, 1),
new CountPerProjectPermission(project1.getId(), ISSUE_ADMIN, 2),
new CountPerProjectPermission(project2.getId(), ISSUE_ADMIN, 1));
}
@Test
public void selectLogins() {
addProjectPermissionOnDefaultOrganization(USER, user1, project1);
addProjectPermissionOnDefaultOrganization(USER, user2, project1);
addProjectPermissionOnDefaultOrganization(ISSUE_ADMIN, user2, project1);
addProjectPermissionOnDefaultOrganization(ISSUE_ADMIN, user2, project2);
// logins are ordered by user name: user2 ("Marie") then user1 ("Marius")
PermissionQuery query = PermissionQuery.builder().setComponentUuid(project1.uuid()).withAtLeastOnePermission().build();
List<String> logins = underTest.selectLogins(dbSession, query);
assertThat(logins).containsExactly(user2.getLogin(), user1.getLogin());
// on a project without permissions
query = PermissionQuery.builder().setComponentUuid("missing").withAtLeastOnePermission().build();
assertThat(underTest.selectLogins(dbSession, query)).isEmpty();
}
@Test
public void deleteGlobalPermission() {
addGlobalPermissionOnDefaultOrganization("perm1", user1);
addGlobalPermissionOnDefaultOrganization("perm2", user1);
addProjectPermissionOnDefaultOrganization("perm1", user1, project1);
addProjectPermissionOnDefaultOrganization("perm3", user2, project1);
addProjectPermissionOnDefaultOrganization("perm4", user2, project2);
// user2 does not have global permissions -> do nothing
underTest.deleteGlobalPermission(dbSession, user2.getId(), "perm1", dbTester.getDefaultOrganization().getUuid());
assertThat(dbTester.countRowsOfTable(dbSession, "user_roles")).isEqualTo(5);
// global permission is not granted -> do nothing
underTest.deleteGlobalPermission(dbSession, user1.getId(), "notGranted", dbTester.getDefaultOrganization().getUuid());
assertThat(dbTester.countRowsOfTable(dbSession, "user_roles")).isEqualTo(5);
// permission is on project -> do nothing
underTest.deleteGlobalPermission(dbSession, user1.getId(), "perm3", dbTester.getDefaultOrganization().getUuid());
assertThat(dbTester.countRowsOfTable(dbSession, "user_roles")).isEqualTo(5);
// global permission on another organization-> do nothing
underTest.deleteGlobalPermission(dbSession, user1.getId(), "notGranted", "anotherOrg");
assertThat(dbTester.countRowsOfTable(dbSession, "user_roles")).isEqualTo(5);
// global permission exists -> delete it, but not the project permission with the same name !
underTest.deleteGlobalPermission(dbSession, user1.getId(), "perm1", dbTester.getDefaultOrganization().getUuid());
assertThat(dbTester.countSql(dbSession, "select count(id) from user_roles where role='perm1' and resource_id is null")).isEqualTo(0);
assertThat(dbTester.countRowsOfTable(dbSession, "user_roles")).isEqualTo(4);
}
@Test
public void deleteProjectPermission() {
addGlobalPermissionOnDefaultOrganization("perm", user1);
addProjectPermissionOnDefaultOrganization("perm", user1, project1);
addProjectPermissionOnDefaultOrganization("perm", user1, project2);
addProjectPermissionOnDefaultOrganization("perm", user2, project1);
// no such provision -> ignore
underTest.deleteProjectPermission(dbSession, user1.getId(), "anotherPerm", project1.getId());
assertThat(dbTester.countRowsOfTable(dbSession, "user_roles")).isEqualTo(4);
underTest.deleteProjectPermission(dbSession, user1.getId(), "perm", project1.getId());
assertThatProjectPermissionDoesNotExist(user1, "perm", project1);
assertThat(dbTester.countRowsOfTable(dbSession, "user_roles")).isEqualTo(3);
}
@Test
public void deleteProjectPermissions() {
addGlobalPermissionOnDefaultOrganization("perm", user1);
addProjectPermissionOnDefaultOrganization("perm", user1, project1);
addProjectPermissionOnDefaultOrganization("perm", user2, project1);
addProjectPermissionOnDefaultOrganization("perm", user1, project2);
underTest.deleteProjectPermissions(dbSession, project1.getId());
assertThat(dbTester.countRowsOfTable(dbSession, "user_roles")).isEqualTo(2);
assertThatProjectHasNoPermissions(project1);
}
@Test
public void projectHasPermissions() {
addGlobalPermissionOnDefaultOrganization(SYSTEM_ADMIN, user1);
addProjectPermissionOnDefaultOrganization(USER, user1, project1);
assertThat(underTest.hasRootComponentPermissions(dbSession, project1.getId())).isTrue();
assertThat(underTest.hasRootComponentPermissions(dbSession, project2.getId())).isFalse();
}
@Test
public void selectGlobalPermissionsOfUser() {
OrganizationDto org = OrganizationTesting.insert(dbTester, newOrganizationDto());
addGlobalPermissionOnDefaultOrganization("perm1", user1);
addGlobalPermissionOnDefaultOrganization("perm2", user2);
addGlobalPermission(org, "perm3", user1);
addProjectPermissionOnDefaultOrganization("perm4", user1, project1);
addProjectPermission(org, "perm5", user1, project1);
assertThat(underTest.selectGlobalPermissionsOfUser(dbSession, user1.getId(), org.getUuid())).containsOnly("perm3");
assertThat(underTest.selectGlobalPermissionsOfUser(dbSession, user1.getId(), dbTester.getDefaultOrganization().getUuid())).containsOnly("perm1");
assertThat(underTest.selectGlobalPermissionsOfUser(dbSession, user1.getId(), "otherOrg")).isEmpty();
assertThat(underTest.selectGlobalPermissionsOfUser(dbSession, user3.getId(), org.getUuid())).isEmpty();
}
@Test
public void selectProjectPermissionsOfUser() {
OrganizationDto org = OrganizationTesting.insert(dbTester, newOrganizationDto());
ComponentDto project3 = dbTester.components().insertProject();
addGlobalPermission(org, "perm1", user1);
addProjectPermission(org, "perm2", user1, project1);
addProjectPermission(org, "perm3", user1, project1);
addProjectPermission(org, "perm4", user1, project2);
addProjectPermission(org, "perm5", user2, project1);
assertThat(underTest.selectProjectPermissionsOfUser(dbSession, user1.getId(), project1.getId())).containsOnly("perm2", "perm3");
assertThat(underTest.selectProjectPermissionsOfUser(dbSession, user1.getId(), project2.getId())).containsOnly("perm4");
assertThat(underTest.selectProjectPermissionsOfUser(dbSession, user1.getId(), project3.getId())).isEmpty();
}
private void expectCount(List<Long> projectIds, CountPerProjectPermission... expected) {
List<CountPerProjectPermission> got = underTest.countUsersByProjectPermission(dbSession, projectIds);
assertThat(got).hasSize(expected.length);
for (CountPerProjectPermission expect : expected) {
boolean found = got.stream().anyMatch(b -> b.getPermission().equals(expect.getPermission()) &&
b.getCount() == expect.getCount() &&
b.getComponentId() == expect.getComponentId());
assertThat(found).isTrue();
}
}
private void expectPermissions(PermissionQuery query, @Nullable Collection<String> logins, UserPermissionDto... expected) {
// test method "select()"
List<ExtendedUserPermissionDto> permissions = underTest.select(dbSession, query, logins);
assertThat(permissions).hasSize(expected.length);
for (int i = 0; i < expected.length; i++) {
ExtendedUserPermissionDto got = permissions.get(i);
UserPermissionDto expect = expected[i];
assertThat(got.getUserId()).isEqualTo(expect.getUserId());
assertThat(got.getPermission()).isEqualTo(expect.getPermission());
assertThat(got.getComponentId()).isEqualTo(expect.getComponentId());
assertThat(got.getUserLogin()).isNotNull();
if (got.getComponentId() != null) {
assertThat(got.getComponentUuid()).isNotNull();
}
}
if (logins == null) {
// test method "countUsers()", which does not make sense if users are filtered
long distinctUsers = Arrays.stream(expected).mapToLong(p -> p.getUserId()).distinct().count();
assertThat((long) underTest.countUsers(dbSession, query)).isEqualTo(distinctUsers);
}
}
private UserPermissionDto addGlobalPermissionOnDefaultOrganization(String permission, UserDto user) {
return addGlobalPermission(dbTester.getDefaultOrganization(), permission, user);
}
private UserPermissionDto addGlobalPermission(OrganizationDto org, String permission, UserDto user) {
UserPermissionDto dto = new UserPermissionDto(org.getUuid(), permission, user.getId(), null);
underTest.insert(dbSession, dto);
dbTester.commit();
return dto;
}
private UserPermissionDto addProjectPermissionOnDefaultOrganization(String permission, UserDto user, ComponentDto project) {
return addProjectPermission(dbTester.getDefaultOrganization(), permission, user, project);
}
private UserPermissionDto addProjectPermission(OrganizationDto org, String permission, UserDto user, ComponentDto project) {
UserPermissionDto dto = new UserPermissionDto(org.getUuid(), permission, user.getId(), project.getId());
underTest.insert(dbSession, dto);
dbTester.commit();
return dto;
}
private void assertThatProjectPermissionDoesNotExist(UserDto user, String permission, ComponentDto project) {
assertThat(dbTester.countSql(dbSession, "select count(id) from user_roles where role='" + permission + "' and user_id=" + user.getId() + " and resource_id=" + project.getId())).isEqualTo(0);
}
private void assertThatProjectHasNoPermissions(ComponentDto project) {
assertThat(dbTester.countSql(dbSession, "select count(id) from user_roles where resource_id=" + project.getId())).isEqualTo(0);
}
}