SONAR-6012 Replace componentPath by componentKey

SonarSource · Jan 21, 2015 · 3d25feb · 3d25feb
1 parent 45e68e7
commit 3d25feb
Show file tree

Hide file tree

Showing 8 changed files with 22 additions and 22 deletions.
diff --git a/server/sonar-server/src/main/java/org/sonar/server/batch/IssuesAction.java b/server/sonar-server/src/main/java/org/sonar/server/batch/IssuesAction.java
@@ -111,7 +111,7 @@ public PreviousIssue apply(@Nullable BatchIssueDto batchIssueDto) {
       if (batchIssueDto != null) {
         return new PreviousIssue()
           .setKey(batchIssueDto.getKey())
-          .setComponentPath(batchIssueDto.getComponentPath())
+          .setComponentKey(batchIssueDto.getComponentKey())
           .setChecksum(batchIssueDto.getChecksum())
           .setAssigneeLogin(batchIssueDto.getAssigneeLogin())
           .setAssigneeFullname(batchIssueDto.getAssigneeName())

diff --git a/server/sonar-server/src/test/java/org/sonar/server/issue/db/IssueDaoTest.java b/server/sonar-server/src/test/java/org/sonar/server/issue/db/IssueDaoTest.java
@@ -155,7 +155,7 @@ public void select_non_closed_issues_by_module_uuid() {
     assertThat(batchIssueDto.getLine()).isEqualTo(200);
     assertThat(batchIssueDto.getResolution()).isEqualTo(Issue.RESOLUTION_FALSE_POSITIVE);
     assertThat(batchIssueDto.getStatus()).isEqualTo(Issue.STATUS_RESOLVED);
-    assertThat(batchIssueDto.getComponentPath()).isEqualTo("src/main/java/Sample.java");
+    assertThat(batchIssueDto.getComponentKey()).isEqualTo("Sample.java");
     assertThat(batchIssueDto.getChecksum()).isEqualTo("123456");
     assertThat(batchIssueDto.getAssigneeLogin()).isEqualTo("john");
     assertThat(batchIssueDto.getAssigneeName()).isEqualTo("John Doo");
@@ -183,7 +183,7 @@ public void select_non_closed_issues_by_project_uuid() {
     assertThat(batchIssueDto.getLine()).isEqualTo(200);
     assertThat(batchIssueDto.getResolution()).isEqualTo(Issue.RESOLUTION_FALSE_POSITIVE);
     assertThat(batchIssueDto.getStatus()).isEqualTo(Issue.STATUS_RESOLVED);
-    assertThat(batchIssueDto.getComponentPath()).isEqualTo("src/main/java/Sample.java");
+    assertThat(batchIssueDto.getComponentKey()).isEqualTo("Sample.java");
     assertThat(batchIssueDto.getChecksum()).isEqualTo("123456");
     assertThat(batchIssueDto.getAssigneeLogin()).isEqualTo("john");
     assertThat(batchIssueDto.getAssigneeName()).isEqualTo("John Doo");

diff --git a/...src/test/resources/org/sonar/server/batch/IssuesActionTest/issues_on_module-expected.json b/...src/test/resources/org/sonar/server/batch/IssuesActionTest/issues_on_module-expected.json
@@ -1,7 +1,7 @@
 [
   {
     "key": "EFGH",
-    "componentPath": "src/main/java/Action.java",
+    "componentKey": "Action.java",
     "ruleKey": "AvoidCycle",
     "ruleRepo": "squid",
     "line": 200,

diff --git a/...rc/test/resources/org/sonar/server/batch/IssuesActionTest/issues_on_project-expected.json b/...rc/test/resources/org/sonar/server/batch/IssuesActionTest/issues_on_project-expected.json
@@ -1,7 +1,7 @@
 [
   {
     "key": "EFGH",
-    "componentPath": "src/main/java/Action.java",
+    "componentKey": "Action.java",
     "ruleKey": "AvoidCycle",
     "ruleRepo": "squid",
     "line": 200,

diff --git a/sonar-batch-protocol/src/main/java/org/sonar/batch/protocol/input/issues/PreviousIssue.java b/sonar-batch-protocol/src/main/java/org/sonar/batch/protocol/input/issues/PreviousIssue.java
@@ -24,7 +24,7 @@
 public class PreviousIssue {
 
   private String key;
-  private String componentPath;
+  private String componentKey;
   private String ruleKey;
   private String ruleRepo;
   private Integer line;
@@ -45,13 +45,13 @@ public String key() {
     return key;
   }
 
-  public PreviousIssue setComponentPath(@Nullable String path) {
+  public PreviousIssue setComponentKey(@Nullable String key) {
-    this.componentPath = path;
+    this.componentKey = key;
     return this;
   }
 
-  public String componentPath() {
+  public String componentKey() {
-    return componentPath;
+    return componentKey;
   }
 
   public PreviousIssue setLine(Integer line) {

diff --git a/...protocol/src/test/java/org/sonar/batch/protocol/input/issues/PreviousIssueHelperTest.java b/...protocol/src/test/java/org/sonar/batch/protocol/input/issues/PreviousIssueHelperTest.java
@@ -38,7 +38,7 @@ public void writeIssues() throws JSONException {
 
     PreviousIssue issue1 = new PreviousIssue();
     issue1.setKey("key1");
-    issue1.setComponentPath("path");
+    issue1.setComponentKey("key");
     issue1.setRuleKey("repokey", "rulekey");
     issue1.setLine(2);
     issue1.setMessage("message");
@@ -58,7 +58,7 @@ public void writeIssues() throws JSONException {
 
     JSONAssert
       .assertEquals(
-        "[{\"key\": \"key1\", \"componentPath\": \"path\", \"ruleKey\": \"rulekey\", \"ruleRepo\": \"repokey\", \"line\": 2,\"message\": \"message\", \"severity\": \"severity\", \"resolution\": \"resolution\", \"status\": \"status\", \"checksum\": \"checksum\",\"assigneeLogin\": \"login\", \"assigneeFullname\": \"fullname\"},"
+        "[{\"key\": \"key1\", \"componentKey\": \"key\", \"ruleKey\": \"rulekey\", \"ruleRepo\": \"repokey\", \"line\": 2,\"message\": \"message\", \"severity\": \"severity\", \"resolution\": \"resolution\", \"status\": \"status\", \"checksum\": \"checksum\",\"assigneeLogin\": \"login\", \"assigneeFullname\": \"fullname\"},"
           +
           "{\"key\": \"key2\"}]",
         out.getBuffer().toString(), true);
@@ -77,7 +77,7 @@ public void readIssues() {
     StringWriter out = new StringWriter();
     PreviousIssueHelper helper = PreviousIssueHelper.create(out);
     StringReader reader = new StringReader(
-      "[{\"key\": \"key1\", \"componentPath\": \"path\", \"ruleKey\": \"rulekey\", \"ruleRepo\": \"repokey\", \"line\": 2,\"message\": \"message\", \"severity\": \"severity\", \"resolution\": \"resolution\", \"status\": \"status\", \"checksum\": \"checksum\",\"assigneeLogin\": \"login\", \"assigneeFullname\": \"fullname\"},"
+      "[{\"key\": \"key1\", \"componentKey\": \"key\", \"ruleKey\": \"rulekey\", \"ruleRepo\": \"repokey\", \"line\": 2,\"message\": \"message\", \"severity\": \"severity\", \"resolution\": \"resolution\", \"status\": \"status\", \"checksum\": \"checksum\",\"assigneeLogin\": \"login\", \"assigneeFullname\": \"fullname\"},"
         +
         "{\"key\": \"key2\"}]");
 
@@ -88,7 +88,7 @@ public void readIssues() {
     assertThat(iterator.hasNext()).isFalse();
 
     assertThat(issue1.key()).isEqualTo("key1");
-    assertThat(issue1.componentPath()).isEqualTo("path");
+    assertThat(issue1.componentKey()).isEqualTo("key");
     assertThat(issue1.ruleRepo()).isEqualTo("repokey");
     assertThat(issue1.ruleKey()).isEqualTo("rulekey");
     assertThat(issue1.line()).isEqualTo(2);

diff --git a/sonar-core/src/main/java/org/sonar/core/issue/db/BatchIssueDto.java b/sonar-core/src/main/java/org/sonar/core/issue/db/BatchIssueDto.java
@@ -30,7 +30,7 @@ public class BatchIssueDto {
   private String checksum;
   private String assigneeLogin;
   private String assigneeName;
-  private String componentPath;
+  private String componentKey;
   private String ruleKey;
   private String ruleRepo;
 
@@ -61,12 +61,12 @@ public BatchIssueDto setChecksum(String checksum) {
     return this;
   }
 
-  public String getComponentPath() {
+  public String getComponentKey() {
-    return componentPath;
+    return componentKey;
   }
 
-  public BatchIssueDto setComponentPath(String componentPath) {
+  public BatchIssueDto setComponentKey(String componentKey) {
-    this.componentPath = componentPath;
+    this.componentKey = componentKey;
     return this;
   }
 

diff --git a/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml b/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml
@@ -192,11 +192,11 @@
     i.checksum as checksum,
     r.plugin_rule_key as ruleKey,
     r.plugin_name as ruleRepo,
-    component.path as componentPath,
+    component.kee as componentKey,
     i.assignee as assigneeLogin,
     u.name as assigneeName
     FROM issues i
-    INNER JOIN (SELECT p.id,p.path FROM projects p WHERE p.module_uuid=#{uuid} OR p.uuid=#{uuid}) component ON component.id=i.component_id
+    INNER JOIN (SELECT p.id,p.kee FROM projects p WHERE p.module_uuid=#{uuid} OR p.uuid=#{uuid}) component ON component.id=i.component_id
     INNER JOIN rules r ON r.id=i.rule_id
     LEFT OUTER JOIN users u ON u.login=i.assignee
     WHERE i.status &lt;&gt; 'CLOSED'
@@ -212,7 +212,7 @@
     i.checksum as checksum,
     r.plugin_rule_key as ruleKey,
     r.plugin_name as ruleRepo,
-    component.path as componentPath,
+    component.kee as componentKey,
     i.assignee as assigneeLogin,
     u.name as assigneeName
     FROM issues i