SONAR-5700 ability to change level of loggers of 3rd-party libraries

server/sonar-process/src/main/java/org/sonar/process/LogbackHelper.java

@@ -204,8 +204,7 @@ public FileAppender createAppender(String appenderName) {
       FixedWindowRollingPolicy rollingPolicy = new FixedWindowRollingPolicy();
       rollingPolicy.setContext(context);
       rollingPolicy.setFileNamePattern(StringUtils.replace(filePath, filenamePrefix + ".log", filenamePrefix + ".%i.log"));
-      rollingPolicy.setMaxIndex(1);
-      rollingPolicy.setMaxIndex(maxFiles);
+      rollingPolicy.setMinIndex(1);
       rollingPolicy.setMaxIndex(maxFiles);
       rollingPolicy.setParent(appender);
       rollingPolicy.start();

sonar-application/src/main/assembly/conf/sonar.properties

@@ -245,10 +245,7 @@
 #--------------------------------------------------------------------------------------------------
 # LOGGING
 
-# Level of information displayed in the logs: NONE (default), BASIC (functional information)
-# and FULL (functional and technical details)
-#sonar.log.profilingLevel=NONE
-
+# Enable debug logs in file sonar.log.
 #sonar.log.debug=false
 
 # Path to log files. Can be absolute or relative to installation directory.
@@ -262,7 +259,9 @@
 #    - disabled if value is "none".  That needs logs to be managed by an external system like logrotate.
 #sonar.log.rollingPolicy=time:yyyy-MM-dd
 
-# Maximum number of files to keep if a rolling policy is enabled
+# Maximum number of files to keep if a rolling policy is enabled.
+#    - maximum value is 20 on size rolling policy
+#    - unlimited on time rolling policy. Set to zero to disable old file purging.
 #sonar.log.maxFiles=7
 
 # Access log is the list of all the HTTP requests received by server. If enabled, it is stored

sonar-plugin-api/pom.xml

@@ -155,6 +155,11 @@
       <artifactId>logback-classic</artifactId>
       <optional>true</optional>
     </dependency>
+    <dependency>
+      <groupId>ch.qos.logback</groupId>
+      <artifactId>logback-core</artifactId>
+      <optional>true</optional>
+    </dependency>
     <dependency>
       <groupId>junit</groupId>
       <artifactId>junit</artifactId>

sonar-plugin-api/src/main/java/org/sonar/api/utils/log/ConsoleLogger.java

@@ -35,7 +35,7 @@ class ConsoleLogger extends BaseLogger {
 
   private final PrintStream stream;
 
-  ConsoleLogger(String unusedName) {
+  ConsoleLogger() {
     this.stream = System.out;
   }
 
@@ -142,6 +142,11 @@ public void doError(String msg, Throwable thrown) {
     thrown.printStackTrace();
   }
 
+  @Override
+  public boolean setLevel(LoggerLevel level) {
+    return false;
+  }
+
   private void log(String level, String msg) {
     this.stream.println(String.format("%s %s", level, msg));
   }

sonar-plugin-api/src/main/java/org/sonar/api/utils/log/ConsoleLoggers.java

@@ -25,7 +25,7 @@ class ConsoleLoggers extends Loggers {
 
   @Override
   protected Logger newInstance(String name) {
-    return new ConsoleLogger(name);
+    return new ConsoleLogger();
   }
 
   @Override

sonar-plugin-api/src/main/java/org/sonar/api/utils/log/LogTester.java

@@ -29,7 +29,7 @@
  * This JUnit rule allows to configure and access logs in tests. By default
  * debug logs are enabled.
  * <p/>
- * Warning - not compatible with parallel execution of tests.
+ * Warning - not compatible with parallel execution of tests in the same JVM fork.
  * <p/>
  * Example:
  * <pre>

sonar-plugin-api/src/main/java/org/sonar/api/utils/log/LogbackLogger.java

@@ -19,106 +19,132 @@
  */
 package org.sonar.api.utils.log;
 
+import ch.qos.logback.classic.*;
+import ch.qos.logback.classic.Logger;
+
 import javax.annotation.Nullable;
 
 /**
- * Note that logback is accessed through SLF4J
+ * Logback is used in production.
  */
 class LogbackLogger extends BaseLogger {
 
-  private final transient org.slf4j.Logger slf4j;
+  private final transient ch.qos.logback.classic.Logger logback;
 
-  LogbackLogger(org.slf4j.Logger slf4j) {
-    this.slf4j = slf4j;
+  LogbackLogger(ch.qos.logback.classic.Logger logback) {
+    this.logback = logback;
   }
 
   @Override
   public boolean isDebugEnabled() {
-    return slf4j.isDebugEnabled();
+    return logback.isDebugEnabled();
   }
 
   @Override
   protected void doDebug(String msg) {
-    slf4j.debug(msg);
+    logback.debug(msg);
   }
 
   @Override
   protected void doDebug(String msg, @Nullable Object arg) {
-    slf4j.debug(msg, arg);
+    logback.debug(msg, arg);
   }
 
   @Override
   protected void doDebug(String msg, @Nullable Object arg1, @Nullable Object arg2) {
-    slf4j.debug(msg, arg1, arg2);
+    logback.debug(msg, arg1, arg2);
   }
 
   @Override
   protected void doDebug(String msg, Object... args) {
-    slf4j.debug(msg, args);
+    logback.debug(msg, args);
   }
 
   @Override
   protected void doInfo(String msg) {
-    slf4j.info(msg);
+    logback.info(msg);
   }
 
   @Override
   protected void doInfo(String msg, @Nullable Object arg) {
-    slf4j.info(msg, arg);
+    logback.info(msg, arg);
   }
 
   @Override
   protected void doInfo(String msg, @Nullable Object arg1, @Nullable Object arg2) {
-    slf4j.info(msg, arg1, arg2);
+    logback.info(msg, arg1, arg2);
   }
 
   @Override
   protected void doInfo(String msg, Object... args) {
-    slf4j.info(msg, args);
+    logback.info(msg, args);
   }
 
   @Override
   protected void doWarn(String msg) {
-    slf4j.warn(msg);
+    logback.warn(msg);
   }
 
   @Override
   protected void doWarn(String msg, @Nullable Object arg) {
-    slf4j.warn(msg, arg);
+    logback.warn(msg, arg);
   }
 
   @Override
   protected void doWarn(String msg, @Nullable Object arg1, @Nullable Object arg2) {
-    slf4j.warn(msg, arg1, arg2);
+    logback.warn(msg, arg1, arg2);
   }
 
   @Override
   protected void doWarn(String msg, Object... args) {
-    slf4j.warn(msg, args);
+    logback.warn(msg, args);
   }
 
   @Override
   protected void doError(String msg) {
-    slf4j.error(msg);
+    logback.error(msg);
   }
 
   @Override
   protected void doError(String msg, @Nullable Object arg) {
-    slf4j.error(msg, arg);
+    logback.error(msg, arg);
   }
 
   @Override
   protected void doError(String msg, @Nullable Object arg1, @Nullable Object arg2) {
-    slf4j.error(msg, arg1, arg2);
+    logback.error(msg, arg1, arg2);
   }
 
   @Override
   protected void doError(String msg, Object... args) {
-    slf4j.error(msg, args);
+    logback.error(msg, args);
   }
 
   @Override
   protected void doError(String msg, Throwable thrown) {
-    slf4j.error(msg, thrown);
+    logback.error(msg, thrown);
+  }
+
+  @Override
+  public boolean setLevel(LoggerLevel level) {
+    switch (level) {
+      case DEBUG:
+        logback.setLevel(Level.DEBUG);
+        break;
+      case INFO:
+        logback.setLevel(Level.INFO);
+        break;
+      case WARN:
+        logback.setLevel(Level.WARN);
+        break;
+      case ERROR:
+        logback.setLevel(Level.ERROR);
+        break;
+    }
+    return true;
+  }
+
+  Logger logbackLogger() {
+    return logback;
   }
 }

sonar-plugin-api/src/main/java/org/sonar/api/utils/log/LogbackLoggers.java

@@ -30,7 +30,8 @@ class LogbackLoggers extends Loggers {
 
   @Override
   protected Logger newInstance(String name) {
-    return new LogbackLogger(LoggerFactory.getLogger(name));
+    // logback is accessed through SLF4J
+    return new LogbackLogger((ch.qos.logback.classic.Logger)LoggerFactory.getLogger(name));
   }
 
   @Override