SONAR-6620 Metric's equals/hashcode should use only the key

SonarSource · Jun 11, 2015 · 97a4b69 · 97a4b69
1 parent ccc92bf
commit 97a4b69
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 11 deletions.
diff --git a/server/sonar-server/src/main/java/org/sonar/server/computation/metric/MetricImpl.java b/server/sonar-server/src/main/java/org/sonar/server/computation/metric/MetricImpl.java
@@ -62,13 +62,12 @@ public boolean equals(@Nullable Object o) {
       return false;
     }
     MetricImpl metric = (MetricImpl) o;
-    return Objects.equals(key, metric.key) &&
+    return Objects.equals(key, metric.key);
-        Objects.equals(type, metric.type);
   }
 
   @Override
   public int hashCode() {
-    return Objects.hash(key, type);
+    return key.hashCode();
   }
 
   @Override

diff --git a/server/sonar-server/src/test/java/org/sonar/server/computation/metric/MetricImplTest.java b/server/sonar-server/src/test/java/org/sonar/server/computation/metric/MetricImplTest.java
@@ -53,24 +53,20 @@ public void verify_getters() {
   }
 
   @Test
-  public void equals_uses_key_and_name() {
+  public void equals_uses_only_key() {
     MetricImpl expected = new MetricImpl(SOME_KEY, SOME_NAME, Metric.MetricType.FLOAT);
 
     assertThat(new MetricImpl(SOME_KEY, SOME_NAME, Metric.MetricType.FLOAT)).isEqualTo(expected);
+    assertThat(new MetricImpl(SOME_KEY, SOME_NAME, Metric.MetricType.STRING)).isEqualTo(expected);
     assertThat(new MetricImpl("some other key", SOME_NAME, Metric.MetricType.FLOAT)).isNotEqualTo(expected);
-    assertThat(new MetricImpl(SOME_KEY, SOME_NAME, Metric.MetricType.STRING)).isNotEqualTo(expected);
   }
 
   @Test
-  public void equals_ignores_valueType() {
+  public void hashcode_uses_only_key() {
-    assertThat(new MetricImpl(SOME_KEY, SOME_NAME, Metric.MetricType.FLOAT)).isEqualTo(new MetricImpl(SOME_KEY, "some other name", Metric.MetricType.FLOAT));
-  }
-
-  @Test
-  public void hashcode_uses_only_key_and_valueType() {
     int expected = new MetricImpl(SOME_KEY, SOME_NAME, Metric.MetricType.FLOAT).hashCode();
 
     assertThat(new MetricImpl(SOME_KEY, "some other name", Metric.MetricType.FLOAT).hashCode()).isEqualTo(expected);
+    assertThat(new MetricImpl(SOME_KEY, "some other name", Metric.MetricType.BOOL).hashCode()).isEqualTo(expected);
   }
 
   @Test