SONAR-6620 rename Metric.getMetricType to getType

server/sonar-server/src/main/java/org/sonar/server/computation/measure/BatchMeasureToMeasure.java

@@ -34,7 +34,7 @@ public Optional<Measure> toMeasure(@Nullable BatchReport.Measure batchMeasure, M
     }
 
     String data = batchMeasure.hasStringValue() ? batchMeasure.getStringValue() : null;
-    switch (metric.getMetricType().getValueType()) {
+    switch (metric.getType().getValueType()) {
       case INT:
         return toIntegerMeasure(batchMeasure, data);
       case LONG:
@@ -50,7 +50,7 @@ public Optional<Measure> toMeasure(@Nullable BatchReport.Measure batchMeasure, M
       case NO_VALUE:
         return toNoValueMeasure(batchMeasure);
       default:
-        throw new IllegalArgumentException("Unsupported Measure.ValueType " + metric.getMetricType().getValueType());
+        throw new IllegalArgumentException("Unsupported Measure.ValueType " + metric.getType().getValueType());
     }
   }
 

server/sonar-server/src/main/java/org/sonar/server/computation/measure/Measure.java

@@ -154,8 +154,6 @@ public String toString() {
    * <p>
    * If the measure type is {@link Measure.ValueType#STRING}, the value returned by this function is the same as {@link #getStringValue()}.
    * </p>
-   *
-   * @throws IllegalStateException if the value type of the measure is not {@link Measure.ValueType#BOOLEAN}
    */
   @CheckForNull
   String getData();

server/sonar-server/src/main/java/org/sonar/server/computation/measure/MeasureDtoToMeasure.java

@@ -37,7 +37,7 @@ public Optional<Measure> toMeasure(@Nullable MeasureDto measureDto, Metric metri
 
     Double value = measureDto.getValue();
     String data = measureDto.getData();
-    switch (metric.getMetricType().getValueType()) {
+    switch (metric.getType().getValueType()) {
       case INT:
         return toIntegerMeasure(measureDto, value, data);
       case LONG:
@@ -53,7 +53,7 @@ public Optional<Measure> toMeasure(@Nullable MeasureDto measureDto, Metric metri
       case NO_VALUE:
         return toNoValueMeasure(measureDto);
       default:
-        throw new IllegalArgumentException("Unsupported Measure.ValueType " + metric.getMetricType().getValueType());
+        throw new IllegalArgumentException("Unsupported Measure.ValueType " + metric.getType().getValueType());
     }
   }
 

server/sonar-server/src/main/java/org/sonar/server/computation/metric/Metric.java

@@ -29,7 +29,7 @@ public interface Metric {
 
   String getName();
 
-  MetricType getMetricType();
+  MetricType getType();
 
   enum MetricType {
     INT(Measure.ValueType.INT),

server/sonar-server/src/main/java/org/sonar/server/computation/metric/MetricImpl.java

@@ -30,12 +30,12 @@ public final class MetricImpl implements Metric {
 
   private final String key;
   private final String name;
-  private final MetricType metricType;
+  private final MetricType type;
 
-  public MetricImpl(String key, String name, MetricType metricType) {
+  public MetricImpl(String key, String name, MetricType type) {
     this.key = requireNonNull(key);
     this.name = requireNonNull(name);
-    this.metricType = requireNonNull(metricType);
+    this.type = requireNonNull(type);
   }
 
   @Override
@@ -49,8 +49,8 @@ public String getName() {
   }
 
   @Override
-  public MetricType getMetricType() {
-    return metricType;
+  public MetricType getType() {
+    return type;
   }
 
   @Override
@@ -63,20 +63,20 @@ public boolean equals(@Nullable Object o) {
     }
     MetricImpl metric = (MetricImpl) o;
     return Objects.equals(key, metric.key) &&
-        Objects.equals(metricType, metric.metricType);
+        Objects.equals(type, metric.type);
   }
 
   @Override
   public int hashCode() {
-    return Objects.hash(key, metricType);
+    return Objects.hash(key, type);
   }
 
   @Override
   public String toString() {
     return com.google.common.base.Objects.toStringHelper(this)
         .add("key", key)
         .add("name", name)
-        .add("metricType", metricType)
+        .add("type", type)
         .toString();
   }
 }

server/sonar-server/src/test/java/org/sonar/server/computation/measure/MeasureRepositoryImplTest.java

@@ -86,9 +86,9 @@ public class MeasureRepositoryImplTest {
   @Before
   public void setUp() throws Exception {
     when(metric1.getKey()).thenReturn(METRIC_KEY_1);
-    when(metric1.getMetricType()).thenReturn(Metric.MetricType.STRING);
+    when(metric1.getType()).thenReturn(Metric.MetricType.STRING);
     when(metric2.getKey()).thenReturn(METRIC_KEY_2);
-    when(metric2.getMetricType()).thenReturn(Metric.MetricType.STRING);
+    when(metric2.getType()).thenReturn(Metric.MetricType.STRING);
 
     // references to metrics are consistent with DB by design
     when(metricRepository.getByKey(METRIC_KEY_1)).thenReturn(metric1);

server/sonar-server/src/test/java/org/sonar/server/computation/metric/MetricImplTest.java

@@ -49,7 +49,7 @@ public void verify_getters() {
 
     assertThat(metric.getKey()).isEqualTo(SOME_KEY);
     assertThat(metric.getName()).isEqualTo(SOME_NAME);
-    assertThat(metric.getMetricType()).isEqualTo(Metric.MetricType.FLOAT);
+    assertThat(metric.getType()).isEqualTo(Metric.MetricType.FLOAT);
   }
 
   @Test
@@ -76,7 +76,7 @@ public void hashcode_uses_only_key_and_valueType() {
   @Test
   public void all_fields_are_displayed_in_toString() {
     assertThat(new MetricImpl(SOME_KEY, SOME_NAME, Metric.MetricType.FLOAT).toString())
-      .isEqualTo("MetricImpl{key=key, name=name, metricType=FLOAT}");
+      .isEqualTo("MetricImpl{key=key, name=name, type=FLOAT}");
 
   }
 }

server/sonar-server/src/test/java/org/sonar/server/computation/metric/MetricRepositoryImplTest.java

@@ -89,7 +89,7 @@ private void verify_mapping_and_valueType_conversion_from_DB_impl(String valueTy
 
     assertThat(metric.getKey()).isEqualTo(metricDto.getKey());
     assertThat(metric.getName()).isEqualTo(metricDto.getShortName());
-    assertThat(metric.getMetricType()).isEqualTo(expected);
+    assertThat(metric.getType()).isEqualTo(expected);
   }
 
   @Test(expected = IllegalArgumentException.class)