Skip to content

Commit

Permalink
rename PlatformLanguageRepository to LanguageRepositoryImpl
Browse files Browse the repository at this point in the history
renaming for consistency
  • Loading branch information
sns-seb committed Jun 18, 2015
1 parent d9027a0 commit f686b7e
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
Expand Up @@ -49,7 +49,7 @@
import org.sonar.server.computation.issue.ScmAccountCache; import org.sonar.server.computation.issue.ScmAccountCache;
import org.sonar.server.computation.issue.ScmAccountCacheLoader; import org.sonar.server.computation.issue.ScmAccountCacheLoader;
import org.sonar.server.computation.issue.SourceLinesCache; import org.sonar.server.computation.issue.SourceLinesCache;
import org.sonar.server.computation.language.PlatformLanguageRepository; import org.sonar.server.computation.language.LanguageRepositoryImpl;
import org.sonar.server.computation.measure.MeasureRepositoryImpl; import org.sonar.server.computation.measure.MeasureRepositoryImpl;
import org.sonar.server.computation.metric.MetricRepositoryImpl; import org.sonar.server.computation.metric.MetricRepositoryImpl;
import org.sonar.server.computation.period.PeriodsHolderImpl; import org.sonar.server.computation.period.PeriodsHolderImpl;
Expand Down Expand Up @@ -136,7 +136,7 @@ private static List componentClasses() {
BatchReportReaderImpl.class, BatchReportReaderImpl.class,


// repositories // repositories
PlatformLanguageRepository.class, LanguageRepositoryImpl.class,
MetricRepositoryImpl.class, MetricRepositoryImpl.class,
MeasureRepositoryImpl.class, MeasureRepositoryImpl.class,
EventRepositoryImpl.class, EventRepositoryImpl.class,
Expand Down
Expand Up @@ -34,15 +34,15 @@
/** /**
* Implementation of {@link LanguageRepository} which find {@link Language} instances available in the container. * Implementation of {@link LanguageRepository} which find {@link Language} instances available in the container.
*/ */
public class PlatformLanguageRepository implements LanguageRepository { public class LanguageRepositoryImpl implements LanguageRepository {


private final Map<String, Language> languagesByKey; private final Map<String, Language> languagesByKey;


public PlatformLanguageRepository() { public LanguageRepositoryImpl() {
this.languagesByKey = Collections.emptyMap(); this.languagesByKey = Collections.emptyMap();
} }


public PlatformLanguageRepository(Language... languages) { public LanguageRepositoryImpl(Language... languages) {
this.languagesByKey = uniqueIndex(filter(asList(languages), notNull()), LanguageToKey.INSTANCE); this.languagesByKey = uniqueIndex(filter(asList(languages), notNull()), LanguageToKey.INSTANCE);
} }


Expand Down
Expand Up @@ -25,33 +25,33 @@


import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThat;


public class PlatformLanguageRepositoryTest { public class LanguageRepositoryImplTest {


private static final String ANY_KEY = "Any_Key"; private static final String ANY_KEY = "Any_Key";
private static final String SOME_LANGUAGE_KEY = "SoMe language_Key"; private static final String SOME_LANGUAGE_KEY = "SoMe language_Key";
private static final Language SOME_LANGUAGE = createLanguage(SOME_LANGUAGE_KEY, "_name"); private static final Language SOME_LANGUAGE = createLanguage(SOME_LANGUAGE_KEY, "_name");


@Test(expected = IllegalArgumentException.class) @Test(expected = IllegalArgumentException.class)
public void constructor_fails_is_language_have_the_same_key() throws Exception { public void constructor_fails_is_language_have_the_same_key() throws Exception {
new PlatformLanguageRepository(createLanguage(SOME_LANGUAGE_KEY, " 1"), createLanguage(SOME_LANGUAGE_KEY, " 2")); new LanguageRepositoryImpl(createLanguage(SOME_LANGUAGE_KEY, " 1"), createLanguage(SOME_LANGUAGE_KEY, " 2"));
} }


@Test @Test
public void find_on_empty_LanguageRepository_returns_absent() throws Exception { public void find_on_empty_LanguageRepository_returns_absent() throws Exception {
assertThat(new PlatformLanguageRepository().find(ANY_KEY).isPresent()).isFalse(); assertThat(new LanguageRepositoryImpl().find(ANY_KEY).isPresent()).isFalse();
} }


@Test @Test
public void find_by_key_returns_the_same_object() throws Exception { public void find_by_key_returns_the_same_object() throws Exception {
PlatformLanguageRepository languageRepository = new PlatformLanguageRepository(SOME_LANGUAGE); LanguageRepositoryImpl languageRepository = new LanguageRepositoryImpl(SOME_LANGUAGE);
Optional<Language> language = languageRepository.find(SOME_LANGUAGE_KEY); Optional<Language> language = languageRepository.find(SOME_LANGUAGE_KEY);
assertThat(language.isPresent()).isTrue(); assertThat(language.isPresent()).isTrue();
assertThat(language.get()).isSameAs(SOME_LANGUAGE); assertThat(language.get()).isSameAs(SOME_LANGUAGE);
} }


@Test @Test
public void find_by_other_key_returns_absent() throws Exception { public void find_by_other_key_returns_absent() throws Exception {
PlatformLanguageRepository languageRepository = new PlatformLanguageRepository(SOME_LANGUAGE); LanguageRepositoryImpl languageRepository = new LanguageRepositoryImpl(SOME_LANGUAGE);
Optional<Language> language = languageRepository.find(ANY_KEY); Optional<Language> language = languageRepository.find(ANY_KEY);
assertThat(language.isPresent()).isFalse(); assertThat(language.isPresent()).isFalse();
} }
Expand Down

0 comments on commit f686b7e

Please sign in to comment.