Fixed: Too big eta in qbit api still occurring on official builds.

Sonarr · Aug 7, 2018 · 3705467 · 3705467
1 parent 86bc5c5
commit 3705467
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/build.sh b/build.sh
@@ -52,15 +52,6 @@ CleanFolder()
     find $path -depth -empty -type d -exec rm -r "{}" \;
 }
 
-
-
-AddJsonNet()
-{
-    rm $outputFolder/Newtonsoft.Json.*
-    cp $sourceFolder/packages/Newtonsoft.Json.*/lib/net35/*.dll $outputFolder
-    cp $sourceFolder/packages/Newtonsoft.Json.*/lib/net35/*.dll $outputFolder/NzbDrone.Update
-}
-
 BuildWithMSBuild()
 {
     export PATH=$msBuild:$PATH
@@ -91,8 +82,6 @@ Build()
 
     CleanFolder $outputFolder false
 
-    AddJsonNet
-
     echo "Removing Mono.Posix.dll"
     rm $outputFolder/Mono.Posix.dll
 

diff --git a/src/NzbDrone.Core.Test/Download/DownloadClientTests/QBittorrentTests/QBittorrentFixture.cs b/src/NzbDrone.Core.Test/Download/DownloadClientTests/QBittorrentTests/QBittorrentFixture.cs
@@ -495,5 +495,18 @@ public void should_get_category_from_the_label_if_the_category_is_not_available(
             var item = Subject.GetItems().Single();
             item.Category.Should().Be(category);
         }
+
+        [Test]
+        public void should_handle_eta_biginteger()
+        {
+            // Let this stand as a lesson to never write temporary unit tests on your dev machine and claim it works.
+            // Commit the tests and let it run with the official build on the official build agents.
+            // (Also don't replace library versions in your build script)
+
+            var json = "{ \"eta\": 18446744073709335000 }";
+            var torrent = Newtonsoft.Json.JsonConvert.DeserializeObject<QBittorrentTorrent>(json);
+            torrent.Eta.ToString().Should().Be("18446744073709335000");
+
+        }
     }
 }