Round-robin over available Download Client #2278

Taloth · 2017-11-08T21:30:27Z

Database Migration

YES - 132
Adding Priority column to DownloadClients, defaults to 1.
Migration numbers enabled clients for backward compat preserving the old 'First' logic.

Description

The round-robin is tested only by unit-tests so far, never actually ran it.
But the problem is that once we do this, it'll round-robin instead of picking the first. Which may affect existing setup and does not allow people to have a 'primary' and 'fallback' mechanism till we have a priority setting.
So up for review, but otherwise parked till we can get that fleshed out.

Todos

Tests
Config option for prioritization instead of round-robin only.

Issues Fixed or Closed by this PR

Support for download client priority #1866

devbrian · 2018-05-07T15:02:02Z

Just wanted to make a note on this, I have been using this in production on my server for a month now with no issues.

devbrian · 2018-11-29T16:05:36Z

Any update on this being added to phantom possibly? @markus101

sachk · 2019-04-20T10:38:11Z

Current status on this? I'd be nice to see this in master.

devbrian · 2019-05-22T14:01:43Z

any chance on getting this added to V3?

fryfrog · 2019-05-28T16:21:45Z

For this to be feasible, I'd think one would need to be able to toggle between round robin and all.

Taloth · 2019-05-29T22:36:56Z

@fryfrog not really, 'all' has no meaning. Currently Sonarr picks the first, or if the first is down, it'll pick the second.

@devbrian Yeah, I'll look into getting it merged in, although 3.x basically means "3.0 or later".

…enabled one

fryfrog · 2019-05-29T22:44:08Z

If you're going to the trouble of adding this "first" or "round-robin" option, you should go to the trouble of also adding an "all" option. I've seen it asked for as much as round robin.

Edit: And by "asked for as much", I've seen both requested maybe twice each. This is a very niche feature. ;)

Taloth · 2019-05-29T22:55:31Z

But how do you envision 'All'? It's not like you want the same torrent to be submitted to all clients simultaneously.

fryfrog · 2019-05-29T23:03:45Z

I certainly don't, nor do I even want round robin. But I've literally had multiple requests by people who want to send them to all their download clients. They both seem about as equally useful to me, which is not very.

All could be used by people w/ a seedbox and local torrents where the seedbox is used for seeding and the local is what they use for importing. It could also be used for multiple uncoordinated sites, kind of the opposite of round robin.

They're all dumb uses and honestly I think this will just complicate the UI for 99% of users. But if you're going to all this trouble to provide a super niche option... at least make the other two people happy too.

Taloth · 2019-05-29T23:14:40Z

But that is a huge complication, because suddenly you have to ignore one client when considering imports. They should have a pp-script to sync the remote torrent to local.
The idea behind round-robin/fallbacks is that you can have have a main client that does most of the work, but a fallback client on a NAS that catches the slack. The current UI allows the user the add multiple clients, but literally the sequence at which you add them determines the priority.
It's definitely a niche feature. I'll probably have to dive into my irc chat logs to find out why I even started working on it, but here we are... 5 inches from the finish.

fryfrog · 2019-05-30T00:27:44Z

Ah, nevermind then :)

…

On Wed, May 29, 2019, 4:14 PM Taloth ***@***.***> wrote: But that is a huge complication, because suddenly you have to ignore one client when considering imports. They should have a pp-script to sync the remote torrent to local. The idea behind round-robin/fallbacks is that you can have have a main client that does most of the work, but a fallback client on a NAS that catches the slack. The current UI allows the user the add multiple clients, but literally the sequence at which you add them determines the priority. It's definitely a niche feature. I'll probably have to dive into my irc chat logs to find out why I even started working on it, but here we are... 5 inches from the finish. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2278?email_source=notifications&email_token=AAAVNRG4CWV3DTIZWICUW3TPX4E6TA5CNFSM4EC4I632YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWQ4Q4A#issuecomment-497141872>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAVNRFERMBWJTT6LWKMV5LPX4E6TANCNFSM4EC4I63Q> .

Taloth · 2019-05-30T09:54:56Z

Added Client Priority and changed to phantom-develop.

@markus101 I opted to put it at the bottom because the hint text meant putting it next to Enable didn't make it look any better.

In the overview I also added a "Prio: x" badge if Prio > 1. It currently has kind.DISABLED because it looks best, but some tweaking there might be necessary.

devbrian · 2019-06-06T21:03:42Z

Hopefully we get a merge soon :). Great work Taloth!

fryfrog · 2019-06-06T21:08:22Z

How about Pri instead of Prio? :)

Edit: Or honestly, you've got Enabled and Disabled, you might as well just do Priority: 1.

Taloth · 2019-06-06T21:14:01Z

Pri could be Primary.

it's waiting for a review from @markus101

fryfrog · 2019-06-06T21:19:21Z

True, so just write the whole word. Don't abbreviate one and not the other. :)

Taloth · 2019-06-06T21:19:43Z

I hate you... 😄

markus101

Haven't tested the full behaviour, but started it up and it's mostly working as expected, just a couple small tweaks then merge it.

markus101 · 2019-06-06T21:26:37Z

frontend/src/Settings/DownloadClients/DownloadClients/DownloadClient.js

+                kind={kinds.DISABLED}
+                outline={true}
+              >
+                Prio: {priority}


I agree with the previous discussion, might as well be Priority: x

markus101 · 2019-06-06T22:07:54Z

src/NzbDrone.Core/Datastore/Migration/132_add_download_client_priority.cs

+                        using (var updateCmd = conn.CreateCommand())
+                        {
+                            updateCmd.Transaction = tran;
+                            updateCmd.CommandText = "UPDATE DownloadClients SET Priority = ? WHERE Id = ?";


Should we be increasing the priority of clients of different types?

I have a torrent client and usenet client enabled, but my torrent client got priority 2 because I added it second. Instead I would expect to see both have a priority of 1.

A simple fix would be to have two counters, one for each protocol.

fryfrog · 2019-06-08T14:44:43Z

:o

Taloth · 2019-06-08T16:33:41Z

Less than 2 years. Got even older branches.

Taloth · 2019-06-11T13:27:58Z

@devbrian Have you been able to test the latest v3 version? (Lidarr/Radarr wants to know if it's safe to port over 😄)

Taloth added enhancement wip labels Nov 8, 2017

Taloth added this to the v3.x milestone Dec 19, 2017

devbrian approved these changes Dec 26, 2017

View reviewed changes

markus101 mentioned this pull request Jul 27, 2018

Multiple Download Clients Issue #2683

Closed

New: Round-robin over available Download Client instead of the first …

a3cbb41

…enabled one

Taloth force-pushed the download-client-roundrobin branch from c8695ba to f3435f9 Compare May 30, 2019 09:48

Taloth removed the wip label May 30, 2019

Taloth changed the base branch from develop to phantom-develop May 30, 2019 09:51

Taloth added the db-migration label May 30, 2019

markus101 approved these changes Jun 6, 2019

View reviewed changes

Support for primary and fallback download client

1d77c40

Taloth force-pushed the download-client-roundrobin branch from cce59fa to 1d77c40 Compare June 8, 2019 13:51

Taloth merged commit 1d77c40 into phantom-develop Jun 8, 2019

Taloth deleted the download-client-roundrobin branch June 8, 2019 16:33

markus101 mentioned this pull request Aug 5, 2019

Support for download client priority #1866

Closed

github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Round-robin over available Download Client #2278

Round-robin over available Download Client #2278

Taloth commented Nov 8, 2017 •

edited

devbrian commented May 7, 2018

devbrian commented Nov 29, 2018

sachk commented Apr 20, 2019

devbrian commented May 22, 2019

fryfrog commented May 28, 2019

Taloth commented May 29, 2019

fryfrog commented May 29, 2019 •

edited

Taloth commented May 29, 2019

fryfrog commented May 29, 2019

Taloth commented May 29, 2019

fryfrog commented May 30, 2019 via email

Taloth commented May 30, 2019 •

edited

devbrian commented Jun 6, 2019

fryfrog commented Jun 6, 2019 •

edited

Taloth commented Jun 6, 2019

fryfrog commented Jun 6, 2019

Taloth commented Jun 6, 2019

markus101 left a comment

markus101 Jun 6, 2019

markus101 Jun 6, 2019

fryfrog commented Jun 8, 2019

Taloth commented Jun 8, 2019

Taloth commented Jun 11, 2019

Round-robin over available Download Client #2278

Round-robin over available Download Client #2278

Conversation

Taloth commented Nov 8, 2017 • edited

Database Migration

Description

Todos

Issues Fixed or Closed by this PR

devbrian commented May 7, 2018

devbrian commented Nov 29, 2018

sachk commented Apr 20, 2019

devbrian commented May 22, 2019

fryfrog commented May 28, 2019

Taloth commented May 29, 2019

fryfrog commented May 29, 2019 • edited

Taloth commented May 29, 2019

fryfrog commented May 29, 2019

Taloth commented May 29, 2019

fryfrog commented May 30, 2019 via email

Taloth commented May 30, 2019 • edited

devbrian commented Jun 6, 2019

fryfrog commented Jun 6, 2019 • edited

Taloth commented Jun 6, 2019

fryfrog commented Jun 6, 2019

Taloth commented Jun 6, 2019

markus101 left a comment

Choose a reason for hiding this comment

markus101 Jun 6, 2019

Choose a reason for hiding this comment

markus101 Jun 6, 2019

Choose a reason for hiding this comment

fryfrog commented Jun 8, 2019

Taloth commented Jun 8, 2019

Taloth commented Jun 11, 2019

Taloth commented Nov 8, 2017 •

edited

fryfrog commented May 29, 2019 •

edited

Taloth commented May 30, 2019 •

edited

fryfrog commented Jun 6, 2019 •

edited