Fix: Wrap routeableipv4 in try catch #6644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
covert8
force-pushed
the
wrap-ipv6-check
branch
2 times, most recently
from
123cf0b
to
6c213ab
Compare
markus101
approved these changes
Mar 23, 2024
|
I'm having some trouble finding how to include the logger when the class is being constructed, could you lend a hand? And it would seem that the functions can't be static any more if we start logging. |
covert8
force-pushed
the
wrap-ipv6-check
branch
from
6c213ab
to
352b221
Compare
markus101
requested changes
Mar 25, 2024
covert8
force-pushed
the
wrap-ipv6-check
branch
2 times, most recently
from
86e98e1
to
6747fc4
Compare
Co-authored-by: Mark McDowall <markus.mcd5@gmail.com>
covert8
force-pushed
the
wrap-ipv6-check
branch
from
6747fc4
to
170258e
Compare
Co-authored-by: Bogdan <mynameisbogdan@users.noreply.github.com>
markus101
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wrap NetworkInterface.GetAllNetworkInterfaces in try catch to solve race condition on aarch64
Database Migration
NO
Issues Fixed or Closed by this PR
Prowlarr unable to access network Prowlarr/Prowlarr#2076