Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Increase rate limit for automatic searches #6659

Conversation

mynameisbogdan
Copy link
Contributor

Description

Since automatic searches are made in the background and some trackers allow 150 requests/hour, with a rate limit of 30s it should not go above this limit.

@markus101
Copy link
Member

I don't think it makes sense to cater to the maximum requests per hour this way, 150/h or 150/15 minutes and then nothing for 45 minutes is still the same thing as long as the indexer is okay with the rate.

@mynameisbogdan
Copy link
Contributor Author

While I agree with no query limit per hour in place, using 150 requests per hour as a baseline for background searches makes sense to me.

When you have few items to search I agree with your logic, but most use automatic searches for the whole library for cutoff unmet or missing which results in way more than 150 searches per hour.

@markus101
Copy link
Member

If we want to impose a limit of 150 requests per hour then that shouldn't be enforced by rate limiting requests to be spread out over the full hour, because it shouldn't matter if they use 150 requests in 10 minutes or 60 minutes, but then we need to track all the requests per indexer.

@mynameisbogdan
Copy link
Contributor Author

I'm closing this one then since your suggestion implies much more work than this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants