update set to return redis response messages #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 30, 2015 11:58
…a callback when nowait is set
1 similar comment
2 similar comments
| $self->{redis}->wait_all_responses unless $self->{nowait}; | ||
| die 'set() requires key and value arguments' unless $key && $value; | ||
|
|
||
| if ($self->{nowait} && (!$callback || ($callback && ref $callback ne 'CODE'))) |
There was a problem hiding this comment.
This is too strict behaviour and potentialy breaks existing application.
Even if nowait with no callbacks, set value is stored later, so callback is not
always required.
Cache::Redis is cache module, so in some case developers can accord delay of cache reflection.
|
Thank you. I add one comment. |
Songmu
added a commit
that referenced
this pull request
Jul 7, 2015
update set to return redis response messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated set() to return the Redis response messages
Also added the option to use a callback when nowait is set
and validate args for set()