Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix latest semver tag retrieval for first time setup #160

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fix latest semver tag retrieval for first time setup #160

merged 1 commit into from
Oct 31, 2023

Conversation

stefafafan
Copy link
Contributor

@stefafafan stefafafan commented Oct 31, 2023

I think tagpr v1.1.3 has a breaking change; when Songmu/tagpr is first setup, the Semver tag retrieval fails and returns "" .

For example, the hatenablog-workflows repository which already has some tags tried to setup tagpr but ended up with the following Pull Request:

This is probably because of #159 ; once you setup .tagpr file manually it works, but first time setup there is no .tagpr so latestSemverTag fails.

I attempted to fix the problem by adding a condition check; if the config is defined check the vPrefix, otherwise return the first value (v1.1.2 behavior).

Here is some example code to show what I want to do: https://go.dev/play/p/OgCCpuethSr

@stefafafan stefafafan marked this pull request as ready for review October 31, 2023 12:00
@Songmu Songmu merged commit 52a0b9c into Songmu:main Oct 31, 2023
3 checks passed
@Songmu
Copy link
Owner

Songmu commented Oct 31, 2023

Oops. Thank you!

@stefafafan stefafafan deleted the fix-default-vprefix branch October 31, 2023 12:20
@stefafafan
Copy link
Contributor Author

Thanks for the quick merge! 😄

@k1LoW
Copy link
Contributor

k1LoW commented Oct 31, 2023

@stefafafan Thank you!!!

@stefafafan
Copy link
Contributor Author

This fix works as intended, thanks again!
hatena/hatenablog-workflows#37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants