Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flag): add a help flag for the feature command #1538

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

C0ZEN
Copy link
Member

@C0ZEN C0ZEN commented Jun 27, 2021

PR Checklist

Please check if your PR fulfils the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated (for bugfix/feature)
  • Docs have been added/updated (for bugfix/feature)

PR Type

What kind of change does this PR introduce?

  • Feature (a new feature)
  • Bugfix (a bug fix)
  • Style (changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc))
  • Refactor (a code change that neither fixes a bug nor adds a feature)
  • Perf (a code change that improves performance)
  • Test (adding missing tests or correcting existing tests)
  • Build (changes that affect the build system, CI configuration or external dependencies)
  • Docs (changes that affect the documentation)
  • Chore (anything else), please describe:

What is the new behaviour?

  • Include a new field when showing the "Empty feature name" to help users to use the --help flag
  • Include a new field when showing the "Wrong feature name" to help users to use the --help flag
  • Add a class to handle easily all the flags with their constraints (duplicate, opposite, etc)
  • Add the logic to detect either or not a flag was specified before the feature name
  • Add the logic to process the flags and execute the related actions

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Closes #735

add a new field to show that a flag --help exists
@C0ZEN C0ZEN added the enhancement Add a new feature/enhancement label Jun 27, 2021
@C0ZEN C0ZEN self-assigned this Jun 27, 2021
@github-actions github-actions bot added the test Contains a change in a test file label Jun 27, 2021
@C0ZEN C0ZEN changed the title feat(help): add more help when encountering the empty feature name feat(flag): add the help flag for the feature command Jun 27, 2021
@C0ZEN C0ZEN changed the title feat(flag): add the help flag for the feature command feat(flag): add a help flag for the feature command Jun 27, 2021
@codecov
Copy link

codecov bot commented Jun 27, 2021

Codecov Report

Merging #1538 (3cabff8) into develop (666d6c9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 3cabff8 differs from pull request most recent head cc4c812. Consider uploading reports for the commit cc4c812 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1538   +/-   ##
========================================
  Coverage    97.33%   97.34%           
========================================
  Files          351      351           
  Lines         7931     7949   +18     
  Branches       795      783   -12     
========================================
+ Hits          7720     7738   +18     
  Misses         211      211           
Flag Coverage Δ
integration 97.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ommand-feature-empty-feature-name-error.service.ts 100.00% <100.00%> (ø)
...ommand-feature-wrong-feature-name-error.service.ts 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Add a new feature/enhancement test Contains a change in a test file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Feature command: help flag
1 participant