fix(logs): properly count the number of processed items within all batches in the logs #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0ZEN
added
merge-into-master 👑
…tches in the logs Only the first batch was taken into consideration. The information was lost during the recursion of batches processing. Fixes #431
C0ZEN
force-pushed
the
bugfix/wrong-batch-count
branch
from
e2b4d1e
to
b3fa660
Compare
Codecov Report
@@ Coverage Diff @@
## develop #436 +/- ##
========================================
Coverage 99.82% 99.82%
========================================
Files 115 115
Lines 2327 2328 +1
Branches 226 227 +1
========================================
+ Hits 2323 2324 +1
Misses 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Code Climate has analyzed commit b3fa660 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 99.8% (0.0% change). View more on Code Climate. |
|
🎉 This PR is included in version 1.43.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the first batch was taken into consideration.
The information was lost during the recursion of batches processing.
Fixes #431
PR Checklist
Please check if your PR fulfils the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behaviour?
What is the new behaviour?
Does this PR introduce a breaking change?
Other information