Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 切换webview报错问题(https://sonic-cloud.wiki/d/1786-200-betawebview) #273

Merged
merged 1 commit into from Oct 24, 2022
Merged

fix: 切换webview报错问题(https://sonic-cloud.wiki/d/1786-200-betawebview) #273

merged 1 commit into from Oct 24, 2022

Conversation

chenyan-master
Copy link

@chenyan-master chenyan-master commented Oct 24, 2022 •
edited

在提出此拉取请求时，我确认了以下几点（保存后请点击复选框）：

  • 标题为fix、feat或doc开头
  • 我已检查没有与此请求重复的拉取请求。
  • 我已经考虑过，并确认这份呈件对其他人很有价值。
  • 我接受此提交可能不会被使用，并根据维护人员的意愿关闭拉取请求。

填写PR内容：
2.0.0-beta版本，切换webview时报异常，详见sonic社区提问: https://sonic-cloud.wiki/d/1786-200-betawebview

@prlabeler prlabeler bot added the fix label Oct 24, 2022
ZhouYixun
ZhouYixun approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@ZhouYixun ZhouYixun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZhouYixun ZhouYixun changed the base branch from main to dev/2.0.0-rc October 24, 2022 07:39
@ZhouYixun ZhouYixun merged commit e6129b8 into SonicCloudOrg:dev/2.0.0-rc Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhouYixun ZhouYixun ZhouYixun approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chenyan-master @ZhouYixun