Add example description to JS warnings #42

JunichiIto · 2023-10-03T09:45:38Z

Output example:

WARN: javascript warning in "displays tooltip" (./spec/system/my_awesome_spec.rb:101)
http://127.0.0.1:53186/packs-test/js/application-1237f3764f27da97575a.js 125177:12 "[BootstrapVue warn]: tooltip - The provided target is no valid HTML element."

JunichiIto · 2023-10-03T09:48:38Z

lib/dekiru/capybara/matchers.rb

@@ -27,7 +31,8 @@ def failure_message
      end

      def have_no_js_errors
-        JsNoErrorMatcher.new
+        example_description = self.inspect.split(' ', 2).last.chop


"#<RSpec::ExampleGroups::Nested::Nested_4::Nested_4 \"displays tooltip\" (./spec/system/my_awesome_spec.rb:101)>"

みたいな文字列から

"\"displays tooltip\" (./spec/system/my_awesome_spec.rb:101)"

だけを抜き出そうとしている。

後からコード見た時にも何をしているか分かるようにコード上にもコメントを足しておいてほしいです。 🙏

Output example: ``` WARN: javascript warning in "displays tooltip" (./spec/system/my_awesome_spec.rb:101) http://127.0.0.1:53186/packs-test/js/application-1237f3764f27da97575a.js 125177:12 "[BootstrapVue warn]: tooltip - The provided target is no valid HTML element." ```

JunichiIto commented Oct 3, 2023

View reviewed changes

JunichiIto force-pushed the refine-js-warning branch from c7bcbcd to 79de1c2 Compare October 4, 2023 01:56

aki77 merged commit e81c165 into master Oct 4, 2023
3 checks passed

aki77 deleted the refine-js-warning branch October 4, 2023 01:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add example description to JS warnings #42

Add example description to JS warnings #42

JunichiIto commented Oct 3, 2023

JunichiIto Oct 3, 2023

aki77 Oct 3, 2023

Add example description to JS warnings #42

Add example description to JS warnings #42

Conversation

JunichiIto commented Oct 3, 2023

JunichiIto Oct 3, 2023

Choose a reason for hiding this comment

aki77 Oct 3, 2023

Choose a reason for hiding this comment