Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler beam search for now #1

Merged
merged 3 commits into from
Jan 14, 2023
Merged

Conversation

gpucce
Copy link

@gpucce gpucce commented Jan 10, 2023

@Soonhwan-Kwon the idea here is to have a simple beam search with a many less options than the HF one, while keeping the same logic, so we can (hopefully) merge it sooner and work on a better one later. What do you think?

Close it, modify it or tell me what you would like to change and I do it if you don't like where this goes

@gpucce
Copy link
Author

gpucce commented Jan 11, 2023

@Soonhwan-Kwon if you think there are too many changes I will revert the last commit, while the first two should allow to run with larger batch sizes, let me know what you prefer!

@Soonhwan-Kwon
Copy link
Owner

@Soonhwan-Kwon if you think there are too many changes I will revert the last commit, while the first two should allow to run with larger batch sizes, let me know what you prefer!

I agree with your direction, but I need to do some tests of it with newly released checkpoint tonight(this is 7pm in my country) to confirm there is no side effect or did you already tested it?

@gpucce
Copy link
Author

gpucce commented Jan 11, 2023

@Soonhwan-Kwon if you think there are too many changes I will revert the last commit, while the first two should allow to run with larger batch sizes, let me know what you prefer!
I agree with your direction, but I need to do some tests of it with newly released checkpoint tonight(this is 7pm in my country) to confirm there is no side effect or did you already tested it?

Oh ok great, didn't mean to rush at all sorry if I did! Let me know anything that does not work! I will also test it and see how things go.

I don't know if you saw this LAION-AI/CLIP_benchmark#63 if you find things that improve validation it might be an idea to add them and later I make it work with the rest of the repo!

@Soonhwan-Kwon
Copy link
Owner

I'm middle of comparing the output, and I expect it will be done this weekend.

@Soonhwan-Kwon Soonhwan-Kwon merged commit d0469ee into Soonhwan-Kwon:coca Jan 14, 2023
@Soonhwan-Kwon
Copy link
Owner

It works very well thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants