feat: #126 move out string closest check to util lib

package.json

@@ -41,7 +41,7 @@
   "dependencies": {
     "@cypress/schema-tools": "^4.7.5",
     "@newdash/inject": "^0.2.22",
-    "@newdash/newdash": "^5.15.0",
+    "@newdash/newdash": "^5.16.0",
     "@odata/metadata": "^0.2.2",
     "@odata/parser": "^0.2.3",
     "bignumber.js": "^9.0.1",

src/error.ts

@@ -40,11 +40,29 @@ export class ForeignKeyValidationError extends StartupError {
 
 
 export class HttpRequestError extends CustomError {
+
   statusCode: number
+  innerErrors: Array<CustomError>
+
   constructor(statusCode: number, message: string) {
     super(message);
     this.statusCode = statusCode;
+    this.innerErrors = [];
   }
+
+  addInnerError(error: CustomError): this {
+    this.innerErrors.push(error);
+    return this;
+  }
+
+  getInnerErrors() {
+    return this.innerErrors;
+  }
+
+  getStatusCode() {
+    return this.statusCode;
+  }
+
 }
 
 export class ServerInternalError extends HttpRequestError {

src/type/index.ts

@@ -5,7 +5,6 @@ export * from './connection';
 export * from './decorators';
 export * from './entity';
 export * from './hooks';
-export * from './libraries';
 export * from './migrate';
 export * from './server';
 export * from './service';

src/type/service.ts

@@ -3,6 +3,7 @@ import { getUnProxyTarget, inject, InjectContainer, LazyRef, noWrap, required, t
 import { forEach } from '@newdash/newdash/forEach';
 import { isArray } from '@newdash/newdash/isArray';
 import { isEmpty } from '@newdash/newdash/isEmpty';
+import { closest } from '@newdash/newdash/string/distance';
 import { defaultParser, ODataFilter, ODataMethod, ODataQueryParam, param, QueryOptionsNode as ODataQuery } from '@odata/parser';
 import 'reflect-metadata';
 import { Connection, DeepPartial, QueryRunner, Repository } from 'typeorm';
@@ -435,13 +436,22 @@ export class TypedService<T = any> extends ODataController {
 
     const msgs = applyValidate(entityType, input, method);
 
+    const columns = Edm.getProperties(entityType);
+
+    // ensure client provide all keys are defined in entity type
+    for (const key of Object.keys(input)) {
+      if (!columns.includes(key)) {
+        msgs.push(`property/navigation '${key}' is not existed on EntityType(${entityName}), did you mean '${closest(key, columns)}'?`);
+      }
+    }
+
     if (msgs.length > 0) {
       throw new BadRequestError(`Entity '${entityName}': ${msgs.join(', ')}`);
     }
 
   }
 
-  // create or update
+  // create or overwrite
   @odata.PUT
   async save(@odata.key key, @odata.body body: DeepPartial<T>) {
     const repo = await this._getRepository();

src/type/validate.ts

@@ -51,6 +51,7 @@ function createColumnValidationRules(entityType: Class, method: ODataMethod) {
   }, {});
   return columnMetaValidationRules;
 }
+
 function createCustomValidationRules(entityType: Class) {
 
   const entityProps = Edm.getProperties(entityType);