fix: avoid update un-necessary field for hana

Soontao · Sep 22, 2020 · dc583cc · dc583cc
1 parent 1cfd3ce
commit dc583cc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/src/edm.ts b/src/edm.ts
@@ -232,17 +232,17 @@ export const GeometryCollection = (function GeometryCollection() {
  *
  * @param returnType
  */
-export function ReturnType<T>(returnType: T): T {
-  return returnType;
+export function ReturnType(returnType: unknown): PropertyDecorator {
+  return returnType as PropertyDecorator;
 }
 
 /**
  * decorator wrapper, indicate user inner decorator means parameter type
  *
  * @param returnType
  */
-export function ParameterType<T>(parameterType: T): T {
-  return parameterType;
+export function ParameterType(parameterType: unknown): ParameterDecorator {
+  return parameterType as ParameterDecorator;
 }
 
 /** Edm.Collection decorator for describing properties as collections */

diff --git a/test/type/school_model/Teacher.ts b/test/type/school_model/Teacher.ts
@@ -36,17 +36,16 @@ export class Teacher {
   // }
   @ODataAction
   async addClass(
-    @Edm.ReturnType(Edm.Int32) classId: number,
+    @Edm.ParameterType(Edm.Int32) classId: number,
     @oInject.service(lazyRef(() => Class)) classService: InjectedTypedService<Class>
   ) {
     const c = await classService.findOne(classId);
 
     if (c === undefined) {
       throw new ResourceNotFoundError(`not found instance class[${classId}]`);
     }
-    c.teacherOneId = this.tid;
 
-    await classService.update(c.cid, c); // save with hooks lifecycle, suggested
+    await classService.update(c.cid, { teacherOneId: this.tid }); // save with hooks lifecycle, suggested
   }
 
   // GET http://localhost:50000/Teachers(1)/Default.queryClass()