Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NFData instances for URIRef #52

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

TOTBWF
Copy link

@TOTBWF TOTBWF commented Feb 24, 2019

No description provided.

@TOTBWF
Copy link
Author

TOTBWF commented Feb 24, 2019

Actually, I see that dddf7b0 removed deepseq as a dependency. This makes it a bit tricky to write NFData instances, so would it be acceptable to bring deepseq back in?

@MichaelXavier
Copy link
Contributor

I wish I would have written a reason for dropping that dependency. Are you sure you need a lower bound that high in deepseq? It seems to be failing one of the LTSes in the build matrix because of it. If so,I don't mind dropping that old of an LTS out of the matrix, but I wouldn't want to do it for no reason. While you're at it, you can go ahead and drop the upper bound too. Over time I've found pessimistic upper bounds to cause more problems than they solve, so I'll probably drop most or all of the upper bounds in the next release of the package.

@TOTBWF
Copy link
Author

TOTBWF commented Feb 26, 2019

I was using deepseq 1.4 for the generics deriving stuff, but I can just use deepseq-generics to handle that, so there isn't any need to drop support.

deepseq-generics allows us to maintain backwards compatibility with
stackage LTS 2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants