generated from googlefonts/googlefonts-project-template
-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
27 changed files
with
0 additions
and
0 deletions.
There are no files selected for viewing
Binary file removed
BIN
-286 KB
fonts/non-COLRv1-for-design-softwares-like-Adobe/non-COLRv1-static_otf/Foldit-Black.otf
Binary file not shown.
Binary file removed
BIN
-291 KB
fonts/non-COLRv1-for-design-softwares-like-Adobe/non-COLRv1-static_otf/Foldit-Bold.otf
Binary file not shown.
Binary file removed
BIN
-288 KB
fonts/non-COLRv1-for-design-softwares-like-Adobe/non-COLRv1-static_otf/Foldit-ExtraBold.otf
Binary file not shown.
Binary file removed
BIN
-281 KB
fonts/non-COLRv1-for-design-softwares-like-Adobe/non-COLRv1-static_otf/Foldit-Light.otf
Binary file not shown.
Binary file removed
BIN
-288 KB
fonts/non-COLRv1-for-design-softwares-like-Adobe/non-COLRv1-static_otf/Foldit-Medium.otf
Binary file not shown.
Binary file removed
BIN
-282 KB
fonts/non-COLRv1-for-design-softwares-like-Adobe/non-COLRv1-static_otf/Foldit-Regular.otf
Binary file not shown.
Binary file removed
BIN
-289 KB
fonts/non-COLRv1-for-design-softwares-like-Adobe/non-COLRv1-static_otf/Foldit-SemiBold.otf
Binary file not shown.
Binary file removed
BIN
-267 KB
fonts/non-COLRv1-for-design-softwares-like-Adobe/non-COLRv1-static_otf/Foldit-Thin.otf
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
e2a27e0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @m4rc1e do you mind if I ask why you removed this folder?
Perhaps it's something I'm not aware of since it's my first project on Github, but I have included also font files that are compatible to use with Adobe softwares in case anyone wanted to use them in this way.
Could you suggest an appropriate way to include these?
e2a27e0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing.
It isn't good practice to commit fonts which have been built locally into the repo for the following reasons:
If we get Github actions to build and release the fonts, the above issues don't exist. This is especially important for us because these fonts are rolled out to millions of people. Basically, we want to minimise errors which have been caused by us humans ;-)
So where should the fonts live? we use github releases for this. This repo's readme includes a bullet point on how to do this. In a nutshell, you create a new release with a version number e.g 1.100, the CI will auto bump the source file's version number then generate the fonts and attach them to the release.
e2a27e0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for explaining @m4rc1e
The font files I would like to include are OpenType SVG format, directly exported from Glyphs3.
As far as I'm aware this is not generated via github Actions, but if I'm wrong please correct me!
e2a27e0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vv-monsalve Just tagging you so you're aware – and maybe if you have a suggestion?
e2a27e0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some previous projects, we've allowed designers to include
otf
folders on their willingness to provide that format, but they ought to be built from our open source tools. That's mandatory from the spec to ensure the scalable font production principle.Now that we rely more on the GH Actions included on repositories based on the template dir, the inclusion of such font dirs has dramatically decreased.
However, @m4rc1e, we still require a fonts folder on the Upstream repository. And I think it would be ideal to keep it, especially if, eventually, we decide to serve only VFs from the API.