Skip to content

Commit

Permalink
rm fonts dir
Browse files Browse the repository at this point in the history
  • Loading branch information
m4rc1e committed Aug 26, 2022
1 parent 8f577fd commit e2a27e0
Show file tree
Hide file tree
Showing 27 changed files with 0 additions and 0 deletions.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed fonts/ttf/Foldit-Black.ttf
Binary file not shown.
Binary file removed fonts/ttf/Foldit-Bold.ttf
Binary file not shown.
Binary file removed fonts/ttf/Foldit-ExtraBold.ttf
Binary file not shown.
Binary file removed fonts/ttf/Foldit-ExtraLight.ttf
Binary file not shown.
Binary file removed fonts/ttf/Foldit-Light.ttf
Binary file not shown.
Binary file removed fonts/ttf/Foldit-Medium.ttf
Binary file not shown.
Binary file removed fonts/ttf/Foldit-Regular.ttf
Binary file not shown.
Binary file removed fonts/ttf/Foldit-SemiBold.ttf
Binary file not shown.
Binary file removed fonts/ttf/Foldit-Thin.ttf
Binary file not shown.
Binary file removed fonts/variable/Foldit[wght].ttf
Binary file not shown.
Binary file removed fonts/webfonts/Foldit-Black.woff2
Binary file not shown.
Binary file removed fonts/webfonts/Foldit-Bold.woff2
Binary file not shown.
Binary file removed fonts/webfonts/Foldit-ExtraBold.woff2
Binary file not shown.
Binary file removed fonts/webfonts/Foldit-ExtraLight.woff2
Binary file not shown.
Binary file removed fonts/webfonts/Foldit-Light.woff2
Binary file not shown.
Binary file removed fonts/webfonts/Foldit-Medium.woff2
Binary file not shown.
Binary file removed fonts/webfonts/Foldit-Regular.woff2
Binary file not shown.
Binary file removed fonts/webfonts/Foldit-SemiBold.woff2
Binary file not shown.
Binary file removed fonts/webfonts/Foldit-Thin.woff2
Binary file not shown.

5 comments on commit e2a27e0

@SophiaDesign
Copy link
Owner

@SophiaDesign SophiaDesign commented on e2a27e0 Aug 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @m4rc1e do you mind if I ask why you removed this folder?

Perhaps it's something I'm not aware of since it's my first project on Github, but I have included also font files that are compatible to use with Adobe softwares in case anyone wanted to use them in this way.

Could you suggest an appropriate way to include these?

@m4rc1e
Copy link
Collaborator Author

@m4rc1e m4rc1e commented on e2a27e0 Aug 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing.

It isn't good practice to commit fonts which have been built locally into the repo for the following reasons:

  • We don't know if you've done further modifications to the fonts
  • You may have committed the wrong fonts
  • You may have built the fonts with different dependencies so they're slightly different.

If we get Github actions to build and release the fonts, the above issues don't exist. This is especially important for us because these fonts are rolled out to millions of people. Basically, we want to minimise errors which have been caused by us humans ;-)

So where should the fonts live? we use github releases for this. This repo's readme includes a bullet point on how to do this. In a nutshell, you create a new release with a version number e.g 1.100, the CI will auto bump the source file's version number then generate the fonts and attach them to the release.

@SophiaDesign
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining @m4rc1e

The font files I would like to include are OpenType SVG format, directly exported from Glyphs3.
As far as I'm aware this is not generated via github Actions, but if I'm wrong please correct me!

@SophiaDesign
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vv-monsalve Just tagging you so you're aware – and maybe if you have a suggestion?

@vv-monsalve
Copy link
Collaborator

@vv-monsalve vv-monsalve commented on e2a27e0 Sep 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some previous projects, we've allowed designers to include otf folders on their willingness to provide that format, but they ought to be built from our open source tools. That's mandatory from the spec to ensure the scalable font production principle.

Now that we rely more on the GH Actions included on repositories based on the template dir, the inclusion of such font dirs has dramatically decreased.

However, @m4rc1e, we still require a fonts folder on the Upstream repository. And I think it would be ideal to keep it, especially if, eventually, we decide to serve only VFs from the API.

Please sign in to comment.