Fix keyword arguments warnings on Ruby 2.7 #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It fixes codes to match method signatures in rails and bcrypt. ## See also - https://github.com/rails/rails/blob/v6.0.3/activerecord/lib/active_record/persistence.rb#L469 - https://github.com/rails/rails/blob/v6.0.3/activemodel/lib/active_model/callbacks.rb - https://github.com/codahale/bcrypt-ruby/blob/v3.1.13/lib/bcrypt/password.rb#L43
|
Hey Team! Do we have an expected timeline for this to PR to get reviewed / released? We just finished our ruby 2.7 upgrade and Thank you! cc @Ch4s3 |
|
Fixes #240 |
joshbuker
approved these changes
Jun 16, 2020
|
CI seems to be borked, but the tests passed previous to the CHANGELOG update, and that should have no effect on any code. Merging into master. |
ochaochaocha3
added a commit
to cre-ne-jp/log-archiver
that referenced
this pull request
Mar 13, 2021
Sorcery/sorcery#241 の変更が取り込まれたので、 masterブランチの指定が不要になった。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes codes to match method signatures in rails and bcrypt.
See also