This repository has been archived by the owner on Dec 17, 2018. It is now read-only.
Add container variable to config
#20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a custom CKContainer to be used for sharing data between multiple apps, like an iOS and macOS app.
Sorix
added a commit
that referenced
this pull request
Feb 3, 2018
Squashed commit of the following:
Update version to 2.0.1
Revert change: FetchAndSaveOperation.allDatabases
Fix unit tests crash
Add `container` variable to config
|
Thank you, pull request has been merged with some changes
|
|
Marked as version 2.0.1 and it is available at CocoaPods 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the great library, Vasily! If you're open to it, I would like to contribute some code to CloudCore as I add features and fix bugs to support my app.
About this PR:
I need to use a custom
CKContainerin my app so that Core Data can sync between an iOS app and a Mac app. I made the following changes to support using a customCKContainer:container: CKContainervariable toCloudCoreConfigCKContainer.default()withCloudCore.config.containerallDatabasesfromFetchAndSaveOperationtoCloudCoreFetchAndSaveOperation.initand passed inallDatabasesfor the appropriate inits (CloudCore, lines 94 and 156)If you have any questions about this or if you would like me to change anything, just let me know. :)