jQuery compatibility?

[dandv]

I found myself writing, out of habit, new Sortable($('#foo')).

Would it be bad if Sortable supported jQuery? The change would be small, I think. Something like this wrapping the constructor:

if (el.jquery) [].concat($.get(el)).forEach( function (el) {
...
}

[FezVrasta]

why don't you write $("#foo")[0] ?

[RubaXa]

Because it returns an instance, so it is not clear what to do in collection hang at first element or all?

[dandv]

The jQuery convention is to preserve method chaining, so the entire collection should be processed, and the resulting Sortable objects should be returned in an array.

[RubaXa]

This is not correct behavior for new.

Correctly will make, ex. so:

if (typeof jQuery !== 'undefined') {
    jQuery.fn.sortable = function (options) {
      return this.each(function () {
          var $el = $(this);
          var sortable = $el.data('sortable');

          if (!sortable && options instanceof Object) {
              sortable = new Sortable(this, options);
              $el.data('sortable', sortable);
          }

          if (sortable && (options in sortable)) {
               sortable[sortable].apply(sortable, [].slice.call(arguments, 1));
          }
      }) 
    };
}

[dandv]

That looks much better.

[njh]

👍 Would be great to have some jQuery support to make things a bit tidier if already using jQuery in a project

[RubaXa]

@dandv @njh @FezVrasta
Done: https://github.com/RubaXa/Sortable/tree/dev/#jq

[njh]

Tested and working great for my limited usage.

I see you updated Sortable.min.js - was this supposed to include the jquery bindings?

[RubaXa]

I see you updated Sortable.min.js - was this supposed to include the jquery bindings?

No.

[RubaXa]

@njh + grunt jquery:min

[njh]

Fantastic!