Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flickering of last item if items have different widths #1686

Closed
vanBrakel opened this issue Nov 17, 2019 · 9 comments
Closed

Flickering of last item if items have different widths #1686

vanBrakel opened this issue Nov 17, 2019 · 9 comments
Labels
enhancement Quality of life changes to existing features

Comments

@vanBrakel
Copy link

Problem:

When using a grid that contains items of different widths, a flickering issue occurs when dragging the last element of the last row. Dragging any other element seems to work fine. This issue appears both on Chrome (78.0.3904.97), Firefox (69.0.1) and IE Edge (44.18362.449.0). Funnily enough, it doesn't appear on IE (11.476.18362.0).

JSFiddle demonstrating the problem: https://jsfiddle.net/qu4ntyl/y63259qv/

example

@owen-m1 owen-m1 added the enhancement Quality of life changes to existing features label Feb 16, 2020
@owen-m1
Copy link
Member

owen-m1 commented Feb 16, 2020

I knew this case was possible, but I didn't solve it because I didn't think anyone would find it 😄

@dzero1
Copy link

dzero1 commented Apr 22, 2021

Having similar problem to this. Any solution?

In my case I guess this happen becase of the placeholder underneath. Check this out

I this case, each "SEED X" item is a sortablejs object. So there will be only one item inside and it'll be the last always.

@EtienneTLM
Copy link

Same issue. In my case it happens randomly, no regard to the item level.

Demo
https://user-images.githubusercontent.com/18191493/124004508-14b2e900-d9a6-11eb-94e2-42a13ead1506.mp4

Initialization
image

Any solution?

@sabuz
Copy link

sabuz commented Feb 21, 2022

@owen-m1 Any update?

@ayushm-agrawal
Copy link

@RubaXa @owen-m1 I am still seeing this issue. Happens when elements have different heights as well. I have forceFallback: true as well. Would really love to get a solution for this

@sabuz
Copy link

sabuz commented Sep 8, 2022

I got a solution. You'll have to add a hidden item at the end, and then disable drop after and sort for that hidden item.

@ayushm-agrawal
Copy link

@sabuz Do you mind creating a quick fiddle with this solution?

@ajacquierbret
Copy link

ajacquierbret commented Jun 29, 2023

Hey folks, it seems to occur because of the threshold of the swap zone. I think this issue must be solved internally, but while there's no fix, try to set the swapThreshold option to something less than 1. By decreasing this option's value (as explained here) little by little, you will see the flicker/jumps happening less and less, until the chances that a user triggers the issue becomes acceptable. For me, setting swapThreshold: 0.5 completely "fixes" the issue.

My two cents guess is that on some configurations, two swap zones overlap each other, triggering multiple swaps at the same time in an infinite loop.

@owen-m1
Copy link
Member

owen-m1 commented Nov 30, 2023

Sorry this took so long to fix. It should be fixed in 1.15.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Quality of life changes to existing features
Projects
None yet
Development

No branches or pull requests

7 participants